Merge pull request #49 from rustaceanrob/26-6-23-boost-follow

rustaceanrob · web-flow · commit 6e9f78f14628 · 2026-06-23T22:56:50.000+02:00
test: Small touchups to the framework
diff --git a/src/test/util/framework.hpp b/src/test/util/framework.hpp
@@ -155,7 +155,7 @@ class TestContext
 private:
     std::atomic<int> m_checks{0};
     std::atomic<int> m_failed{0};
-    bool m_did_throw{false};
+    std::atomic<bool> m_did_throw{false};
     const std::string m_full_name;
     const std::thread::id m_owner_thread{std::this_thread::get_id()};
 
@@ -185,12 +185,12 @@ class TestContext
 
     void exception_occured()
     {
-        m_did_throw = true;
+        m_did_throw.store(true, std::memory_order_relaxed);
     }
 
-    bool did_fail()
+    bool passed()
     {
-        return m_did_throw || m_failed.load(std::memory_order_relaxed) > 0;
+        return !m_did_throw.load(std::memory_order_relaxed) || m_failed.load(std::memory_order_relaxed) == 0;
     }
 
     TestStats stats() const noexcept
@@ -514,7 +514,7 @@ inline int run(int argc, char** argv)
         }
         const auto stats = ctx.stats();
         summary.total_checks += stats.checks;
-        if (!ctx.did_fail()) {
+        if (ctx.passed()) {
             ++summary.passed;
             log(LogLevel::Info, "[ OK ] %s (%d checks)\n", test_case.name, stats.checks);
         } else {

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ class TestContext`
`155`	`155`	`private:`
`156`	`156`	`std::atomic<int> m_checks{0};`
`157`	`157`	`std::atomic<int> m_failed{0};`
`158`		`- bool m_did_throw{false};`
	`158`	`+ std::atomic<bool> m_did_throw{false};`
`159`	`159`	`const std::string m_full_name;`
`160`	`160`	`const std::thread::id m_owner_thread{std::this_thread::get_id()};`
`161`	`161`
`@@ -185,12 +185,12 @@ class TestContext`
`185`	`185`
`186`	`186`	`void exception_occured()`
`187`	`187`	`{`
`188`		`- m_did_throw = true;`
	`188`	`+ m_did_throw.store(true, std::memory_order_relaxed);`
`189`	`189`	`}`
`190`	`190`
`191`		`- bool did_fail()`
	`191`	`+ bool passed()`
`192`	`192`	`{`
`193`		`- return m_did_throw \|\| m_failed.load(std::memory_order_relaxed) > 0;`
	`193`	`+ return !m_did_throw.load(std::memory_order_relaxed) \|\| m_failed.load(std::memory_order_relaxed) == 0;`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`TestStats stats() const noexcept`
`@@ -514,7 +514,7 @@ inline int run(int argc, char** argv)`
`514`	`514`	`}`
`515`	`515`	`const auto stats = ctx.stats();`
`516`	`516`	`summary.total_checks += stats.checks;`
`517`		`- if (!ctx.did_fail()) {`
	`517`	`+ if (ctx.passed()) {`
`518`	`518`	`++summary.passed;`
`519`	`519`	`log(LogLevel::Info, "[ OK ] %s (%d checks)\n", test_case.name, stats.checks);`
`520`	`520`	`} else {`