chore: simplify and clean up detekt report tasks and unused test error validation logic

Author: jreynard-code

api/src/integrationTest/kotlin/com/cosmotech/api/home/organization/OrganizationConstants.kt

@@ -28,8 +28,5 @@ object OrganizationConstants {
         """{"id":"$NEW_USER_ID","role":"$NEW_USER_ROLE"}"""
   }
 
-  object Errors {
-    val emptyNameOrganizationCreationRequestError =
-        """{"type":"https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400","title":"Bad Request","status":400,"detail":"name: cannot be empty","instance":"/organizations"}"""
-  }
+  object Errors {}
 }

api/src/integrationTest/kotlin/com/cosmotech/api/home/organization/OrganizationControllerTests.kt

@@ -6,7 +6,6 @@ import com.cosmotech.api.home.Constants.PLATFORM_ADMIN_EMAIL
 import com.cosmotech.api.home.ControllerTestBase
 import com.cosmotech.api.home.ControllerTestUtils.OrganizationUtils.constructOrganizationCreateRequest
 import com.cosmotech.api.home.ControllerTestUtils.OrganizationUtils.createOrganizationAndReturnId
-import com.cosmotech.api.home.organization.OrganizationConstants.Errors.emptyNameOrganizationCreationRequestError
 import com.cosmotech.api.home.organization.OrganizationConstants.NEW_ORGANIZATION_NAME
 import com.cosmotech.api.home.organization.OrganizationConstants.NEW_USER_ID
 import com.cosmotech.api.home.organization.OrganizationConstants.NEW_USER_ROLE
@@ -21,7 +20,6 @@ import com.cosmotech.api.home.withPlatformAdminHeader
 import com.cosmotech.common.rbac.ROLE_ADMIN
 import com.cosmotech.common.rbac.ROLE_NONE
 import com.cosmotech.common.rbac.ROLE_VIEWER
-import kotlin.test.assertEquals
 import org.json.JSONObject
 import org.junit.jupiter.api.Test
 import org.slf4j.LoggerFactory
@@ -378,44 +376,18 @@ class OrganizationControllerTests : ControllerTestBase() {
 
   @Test
   fun create_organization_with_empty_name() {
-    val responseContent =
-        JSONObject(
-            mvc.perform(
-                    post("/organizations")
-                        .contentType(MediaType.APPLICATION_JSON)
-                        .withPlatformAdminHeader()
-                        .content(EMPTY_NAME_ORGANIZATION_REQUEST_CREATION)
-                        .accept(MediaType.APPLICATION_JSON)
-                        .with(csrf())
-                )
-                .andExpect(status().is4xxClientError)
-                .andExpect(status().isBadRequest)
-                .andDo(MockMvcResultHandlers.print())
-                .andReturn()
-                .response
-                .contentAsString
+    mvc.perform(
+            post("/organizations")
+                .contentType(MediaType.APPLICATION_JSON)
+                .withPlatformAdminHeader()
+                .content(EMPTY_NAME_ORGANIZATION_REQUEST_CREATION)
+                .accept(MediaType.APPLICATION_JSON)
+                .with(csrf())
         )
-
-    assertEquals(
-        JSONObject(emptyNameOrganizationCreationRequestError).get("detail"),
-        responseContent.get("detail"),
-    )
-    assertEquals(
-        JSONObject(emptyNameOrganizationCreationRequestError).get("title"),
-        responseContent.get("title"),
-    )
-    assertEquals(
-        JSONObject(emptyNameOrganizationCreationRequestError).get("status"),
-        responseContent.get("status"),
-    )
-    assertEquals(
-        JSONObject(emptyNameOrganizationCreationRequestError).get("instance"),
-        responseContent.get("instance"),
-    )
-    assertEquals(
-        JSONObject(emptyNameOrganizationCreationRequestError).get("type"),
-        responseContent.get("type"),
-    )
+        .andExpect(status().is4xxClientError)
+        .andExpect(status().isBadRequest)
+        .andExpect(jsonPath("$.detail").value("name: cannot be empty"))
+        .andDo(MockMvcResultHandlers.print())
   }
 
   @Test

build.gradle.kts

@@ -615,10 +615,9 @@ tasks.getByName("spotlessKotlinGradle") {
 val copySubProjectsDetektReportsTasks =
     subprojects.flatMap { subProject ->
       listOf("html", "xml", "txt", "sarif").map { format ->
-        val formatCapitalized = format
         val copyTask =
             tasks.register<Copy>(
-                "detektCopy${formatCapitalized}ReportFor" +
+                "detektCopy${format}ReportFor" +
                     "${subProject.projectDir.relativeTo(rootDir)}".replace("/", "_")
             ) {
               group = "detekt"