Add CLI tests for attachments and help commands

Dicklesworthstone · claude · Dicklesworthstone · commit 218307a7b9ee · 2025-12-16T02:15:32.000-06:00
- attachments_test.go: Tests for CollectAttachments function - help_test.go: Tests for help display functions (clampWidth, detectWidth, etc.) Coverage improved from 46.1% to 49.6% 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
diff --git a/internal/cli/attachments_test.go b/internal/cli/attachments_test.go
@@ -0,0 +1,163 @@
+package cli
+
+import (
+	"context"
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/Dicklesworthstone/slb/internal/testutil"
+)
+
+func TestCollectAttachments_EmptyFlags(t *testing.T) {
+	_ = testutil.NewHarness(t) // Ensure test cleanup
+
+	flags := AttachmentFlags{}
+	attachments, err := CollectAttachments(context.Background(), flags)
+
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	if len(attachments) != 0 {
+		t.Errorf("expected 0 attachments with empty flags, got %d", len(attachments))
+	}
+}
+
+func TestCollectAttachments_FileAttachment(t *testing.T) {
+	h := testutil.NewHarness(t)
+
+	// Create a test file
+	testFile := filepath.Join(h.ProjectDir, "test.txt")
+	if err := os.WriteFile(testFile, []byte("test content"), 0644); err != nil {
+		t.Fatalf("failed to create test file: %v", err)
+	}
+
+	flags := AttachmentFlags{
+		Files: []string{testFile},
+	}
+
+	attachments, err := CollectAttachments(context.Background(), flags)
+
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	if len(attachments) != 1 {
+		t.Fatalf("expected 1 attachment, got %d", len(attachments))
+	}
+	// Attachment has Type, Content, and Metadata fields
+	if attachments[0].Type != "file" {
+		t.Errorf("expected type 'file', got %q", attachments[0].Type)
+	}
+	if attachments[0].Content == "" {
+		t.Error("expected non-empty content")
+	}
+}
+
+func TestCollectAttachments_FileNotFound(t *testing.T) {
+	_ = testutil.NewHarness(t)
+
+	flags := AttachmentFlags{
+		Files: []string{"/nonexistent/path/file.txt"},
+	}
+
+	_, err := CollectAttachments(context.Background(), flags)
+
+	if err == nil {
+		t.Fatal("expected error for nonexistent file")
+	}
+}
+
+func TestCollectAttachments_MultipleFiles(t *testing.T) {
+	h := testutil.NewHarness(t)
+
+	// Create test files
+	file1 := filepath.Join(h.ProjectDir, "file1.txt")
+	file2 := filepath.Join(h.ProjectDir, "file2.txt")
+	if err := os.WriteFile(file1, []byte("content 1"), 0644); err != nil {
+		t.Fatalf("failed to create test file: %v", err)
+	}
+	if err := os.WriteFile(file2, []byte("content 2"), 0644); err != nil {
+		t.Fatalf("failed to create test file: %v", err)
+	}
+
+	flags := AttachmentFlags{
+		Files: []string{file1, file2},
+	}
+
+	attachments, err := CollectAttachments(context.Background(), flags)
+
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	if len(attachments) != 2 {
+		t.Errorf("expected 2 attachments, got %d", len(attachments))
+	}
+}
+
+func TestCollectAttachments_ContextCommand(t *testing.T) {
+	_ = testutil.NewHarness(t)
+
+	flags := AttachmentFlags{
+		Contexts: []string{"echo hello"},
+	}
+
+	attachments, err := CollectAttachments(context.Background(), flags)
+
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	if len(attachments) != 1 {
+		t.Fatalf("expected 1 attachment, got %d", len(attachments))
+	}
+	// Context commands produce a "context" type attachment
+	if attachments[0].Type != "context" {
+		t.Errorf("expected type 'context', got %q", attachments[0].Type)
+	}
+}
+
+func TestCollectAttachments_FailingContextCommand(t *testing.T) {
+	_ = testutil.NewHarness(t)
+
+	flags := AttachmentFlags{
+		Contexts: []string{"nonexistent-command-xyz"},
+	}
+
+	_, err := CollectAttachments(context.Background(), flags)
+
+	// Command may or may not fail depending on shell behavior
+	// Just verify no panic occurs
+	_ = err
+}
+
+func TestCollectAttachments_ScreenshotNotFound(t *testing.T) {
+	_ = testutil.NewHarness(t)
+
+	flags := AttachmentFlags{
+		Screenshots: []string{"/nonexistent/screenshot.png"},
+	}
+
+	_, err := CollectAttachments(context.Background(), flags)
+
+	if err == nil {
+		t.Fatal("expected error for nonexistent screenshot")
+	}
+}
+
+func TestAttachmentFlags_Struct(t *testing.T) {
+	// Verify AttachmentFlags struct can be used properly
+	flags := AttachmentFlags{
+		Files:       []string{"file1.txt", "file2.txt"},
+		Contexts:    []string{"ls -la", "git status"},
+		Screenshots: []string{"screen.png"},
+	}
+
+	if len(flags.Files) != 2 {
+		t.Errorf("expected 2 files, got %d", len(flags.Files))
+	}
+	if len(flags.Contexts) != 2 {
+		t.Errorf("expected 2 contexts, got %d", len(flags.Contexts))
+	}
+	if len(flags.Screenshots) != 1 {
+		t.Errorf("expected 1 screenshot, got %d", len(flags.Screenshots))
+	}
+}
diff --git a/internal/cli/help_test.go b/internal/cli/help_test.go
@@ -0,0 +1,192 @@
+package cli
+
+import (
+	"os"
+	"testing"
+
+	"github.com/charmbracelet/lipgloss"
+)
+
+func TestClampWidth(t *testing.T) {
+	tests := []struct {
+		input    int
+		expected int
+	}{
+		{50, 72},   // Below minimum, clamp to 72
+		{72, 72},   // At minimum
+		{80, 80},   // Normal width
+		{100, 100}, // At maximum
+		{120, 100}, // Above maximum, clamp to 100
+		{200, 100}, // Well above maximum
+	}
+
+	for _, tt := range tests {
+		result := clampWidth(tt.input)
+		if result != tt.expected {
+			t.Errorf("clampWidth(%d) = %d, want %d", tt.input, result, tt.expected)
+		}
+	}
+}
+
+func TestDetectWidth(t *testing.T) {
+	// Test with COLUMNS env var
+	originalColumns := os.Getenv("COLUMNS")
+	defer os.Setenv("COLUMNS", originalColumns)
+
+	os.Setenv("COLUMNS", "120")
+	width := detectWidth()
+	// The result may vary depending on whether stdout is a terminal
+	if width <= 0 {
+		t.Errorf("detectWidth() returned %d, expected positive value", width)
+	}
+
+	// Test with invalid COLUMNS
+	os.Setenv("COLUMNS", "invalid")
+	width = detectWidth()
+	// Should fall back to default (80) or terminal width
+	if width <= 0 {
+		t.Errorf("detectWidth() returned %d, expected positive value", width)
+	}
+
+	// Test with empty COLUMNS
+	os.Setenv("COLUMNS", "")
+	width = detectWidth()
+	if width <= 0 {
+		t.Errorf("detectWidth() returned %d, expected positive value", width)
+	}
+}
+
+func TestSupportsUnicode(t *testing.T) {
+	// Save original environment
+	originalTerm := os.Getenv("TERM")
+	originalLcAll := os.Getenv("LC_ALL")
+	originalLcCtype := os.Getenv("LC_CTYPE")
+	originalLang := os.Getenv("LANG")
+
+	defer func() {
+		os.Setenv("TERM", originalTerm)
+		os.Setenv("LC_ALL", originalLcAll)
+		os.Setenv("LC_CTYPE", originalLcCtype)
+		os.Setenv("LANG", originalLang)
+	}()
+
+	// Test with dumb terminal
+	os.Setenv("TERM", "dumb")
+	os.Setenv("LC_ALL", "")
+	os.Setenv("LC_CTYPE", "")
+	os.Setenv("LANG", "")
+	if supportsUnicode() {
+		t.Error("expected supportsUnicode() = false for dumb terminal")
+	}
+
+	// Test with UTF-8 locale
+	os.Setenv("TERM", "xterm")
+	os.Setenv("LC_ALL", "en_US.UTF-8")
+	if !supportsUnicode() {
+		t.Error("expected supportsUnicode() = true for UTF-8 locale")
+	}
+
+	// Test with utf8 in LANG
+	os.Setenv("LC_ALL", "")
+	os.Setenv("LANG", "C.utf8")
+	if !supportsUnicode() {
+		t.Error("expected supportsUnicode() = true for utf8 in LANG")
+	}
+}
+
+func TestGradientText(t *testing.T) {
+	// Save original environment for Unicode check
+	originalLang := os.Getenv("LANG")
+	defer os.Setenv("LANG", originalLang)
+
+	os.Setenv("LANG", "en_US.UTF-8")
+	os.Setenv("TERM", "xterm")
+
+	// Test with no colors
+	result := gradientText("hello", nil)
+	if result != "hello" {
+		t.Errorf("expected 'hello' with no colors, got %q", result)
+	}
+
+	// Test with colors - just verify no panic
+	result = gradientText("hello", []lipgloss.Color{colorMauve, colorBlue})
+	if result == "" {
+		t.Error("expected non-empty result")
+	}
+}
+
+func TestBullet(t *testing.T) {
+	result := bullet("slb run", "run a command")
+
+	// Should contain the command
+	if result == "" {
+		t.Error("expected non-empty bullet result")
+	}
+
+	// Result should contain the command text
+	// The styling makes exact matching difficult, but the content should be there
+}
+
+func TestRenderSection(t *testing.T) {
+	lines := []string{
+		"  line 1",
+		"  line 2",
+	}
+
+	// Test with unicode
+	result := renderSection(true, "🔷 Test Section", lines)
+	if result == "" {
+		t.Error("expected non-empty section result with unicode")
+	}
+
+	// Test without unicode
+	result = renderSection(false, "🔷 Test Section", lines)
+	if result == "" {
+		t.Error("expected non-empty section result without unicode")
+	}
+}
+
+func TestTierLegend(t *testing.T) {
+	// Test with unicode
+	result := tierLegend(true)
+	if result == "" {
+		t.Error("expected non-empty tier legend with unicode")
+	}
+
+	// Test without unicode
+	result = tierLegend(false)
+	if result == "" {
+		t.Error("expected non-empty tier legend without unicode")
+	}
+}
+
+func TestFlagLegend(t *testing.T) {
+	// Test with unicode
+	result := flagLegend(true)
+	if result == "" {
+		t.Error("expected non-empty flag legend with unicode")
+	}
+
+	// Test without unicode
+	result = flagLegend(false)
+	if result == "" {
+		t.Error("expected non-empty flag legend without unicode")
+	}
+}
+
+func TestFooterLegend(t *testing.T) {
+	// Test with unicode
+	result := footerLegend(true)
+	if result == "" {
+		t.Error("expected non-empty footer legend with unicode")
+	}
+
+	// Test without unicode
+	result = footerLegend(false)
+	if result == "" {
+		t.Error("expected non-empty footer legend without unicode")
+	}
+}
+
+// Ensure lipgloss import is used
+var _ lipgloss.Color
