From cdc5d941dc601807004a107c0551b86040b283c3 Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Mon, 15 Jul 2024 11:38:11 -0300 Subject: [PATCH] fix: fix off-by-one error in overflow handling --- .../resources/META-INF/frontend/fcEnhancedTabs/connector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/META-INF/frontend/fcEnhancedTabs/connector.js b/src/main/resources/META-INF/frontend/fcEnhancedTabs/connector.js index 3e24aca..5204c9a 100644 --- a/src/main/resources/META-INF/frontend/fcEnhancedTabs/connector.js +++ b/src/main/resources/META-INF/frontend/fcEnhancedTabs/connector.js @@ -65,7 +65,7 @@ buttons = tabs._buttons; const selectedIndex = buttons.findIndex(e=>e.item.component && e.item.component.querySelector('vaadin-tab[selected]')); let overflowIndex = buttons.findIndex(e=>e.style.visibility); - while (selectedIndex>=overflowIndex && overflowIndex>0 && buttons[selectedIndex].style.visibility) { + while (selectedIndex>=overflowIndex && overflowIndex>=0 && buttons[selectedIndex].style.visibility) { buttons[0].parentElement.insertBefore(buttons[selectedIndex], buttons[overflowIndex--]); __detectOverflow(); buttons[selectedIndex]._position = selectedIndex;