CR feedback

Author: labkey-martyp

.agents/review-checklists/jest/business-logic.md

@@ -17,7 +17,6 @@ Flag as a high-severity finding when the test would still pass after removing th
 ### Exceptions / False Positives
 
 - Allow explicit smoke tests when the purpose is only to verify the component/function does not throw on render or initialization.
-- Do not flag helper tests that intentionally validate test utilities/builders rather than product behavior, if the subject under test is the utility itself.
 - A simple existence assertion can be acceptable when the behavior under review is conditional presence/absence itself (for example, permission-gated rendering).
 
 ### Detection heuristic
@@ -53,6 +52,7 @@ expect(data[0].name).toBe('Alpha'); // This tests your test, not your code
 // ✅ GOOD — asserts on rendered output from that input
 const data = [{ name: 'Alpha', value: 10 }];
 render(<Table rows={data} />);
-expect(screen.getByText('Alpha')).toBeInTheDocument();
-expect(screen.getByText('10')).toBeInTheDocument();
+const row = screen.getByRole('row', { name: /alpha\s+10/i });
+expect(within(row).getByRole('cell', { name: 'Alpha' })).toBeInTheDocument();
+expect(within(row).getByRole('cell', { name: '10' })).toBeInTheDocument();
 ```

.claude/skills/code-review-jest/skill.md

@@ -1,12 +1,12 @@
 ---
 name: code-review-jest
-description: "Trigger when the user requests a review of Jest test files (e.g., `.test.tsx`, `.spec.tsx`). Supports --full flag for complete file/directory review; defaults to staged changes when a path is provided."
+description: "Trigger when the user requests a review of Jest test files (e.g., `.test.tsx`, `.test.ts`). Supports --full flag for complete file/directory review; defaults to staged changes when a path is provided."
 ---
 
 # Jest Test Code Review
 
 ## Intent
-Use this skill whenever the user asks to review Jest test code (especially `.test.tsx`, `.spec.tsx`, `.test.ts`, or `.spec.ts` files). Support three review modes:
+Use this skill whenever the user asks to review Jest test code (especially `.test.tsx` or `.test.ts` files). Support three review modes:
 
 1. **Pending-change review** – bare invocation with no arguments; inspects staged/working-tree
    files slated for commit across all repos.
@@ -36,7 +36,7 @@ Parse the invocation arguments to extract:
   running `find server/modules -maxdepth 2 -name ".git" -type d` from the workspace root,
   then for each discovered repo (and the top-level root) run `git diff --cached --name-only`
   and `git diff --name-only`. Aggregate all results, filtering to test file extensions
-  (`.test.tsx`, `.spec.tsx`, `.test.ts`, `.spec.ts`).
+  (`.test.tsx` or `.test.ts`).
 
 - **Path provided (no `--full` flag — default):** Determine the git root via
   `git -C <path> rev-parse --show-toplevel`.