Can anyone tell what in this patch is bad for you?

[Anixx]

This is the patch for support of Classic theme, written years ago by Valinet, the author of Explorer Patcher.

The patch mostly replaces the OpenShell's hardcoded colors with those fetched from the system and allows to texture the non-themed taskbar. Can anyone tell what in this patch is so objectionable that it is not merged for years? Why the users are forced to re-compile Classic/Open Shell?

diff --git a/StartMenuDLL_old.cpp b/StartMenuDLL.cpp
index b77e1cb..7ff7c12 100755
--- a/StartMenuDLL_old.cpp
+++ b/StartMenuDLL.cpp
@@ -1786,6 +1786,7 @@ static LRESULT CALLBACK SubclassTaskBarProc( HWND hWnd, UINT uMsg, WPARAM wParam
 		ComputeTaskbarColors(data);
 		WINCOMPATTRDATA attrData={0x13,&data,sizeof(data)};
 		SetWindowCompositionAttribute(hWnd,&attrData);
+		UpdateTaskBars(TASKBAR_UPDATE_TEXTURE);
 		return res;
 	}
 	if ((uMsg==WM_DWMCOLORIZATIONCOLORCHANGED || uMsg==WM_SETTINGCHANGE) && taskBar && taskBar->bCustomLook && SetWindowCompositionAttribute && GetWinVersion()<WIN_VER_WIN10)
@@ -1846,7 +1847,7 @@ static LRESULT CALLBACK SubclassTaskBarProc( HWND hWnd, UINT uMsg, WPARAM wParam
 				WINCOMPATTRDATA attrData={0x13,&data,sizeof(data)};
 				SetWindowCompositionAttribute(hWnd,&attrData);
 			}
-			if (g_TaskbarTexture && IsAppThemed())
+			if (g_TaskbarTexture)// && IsAppThemed())
 			{
 				// draw taskbar background (behind start button and separators)
 				PAINTSTRUCT ps;
@@ -2282,12 +2283,13 @@ void UpdateTaskBars( TUpdateTaskbar update )
 					}
 				}
 			}
-			else if (GetWinVersion()<WIN_VER_WIN10 && (!bDefColor || !bDefOpacity))
+			else //if (GetWinVersion()<WIN_VER_WIN10 && (!bDefColor || !bDefOpacity))
 			{
-				if (bDefColor && GetWinVersion()>WIN_VER_WIN7)
+				//if (bDefColor && GetWinVersion()>WIN_VER_WIN7)
 				{
-					color=GetSystemGlassColor8();
-					color=((color&0xFF)<<16)|(color&0xFF00)|((color>>16)&0xFF);
+					//color=GetSystemGlassColor8();
+					color=GetSysColor(COLOR_BTNFACE);
+					//color=((color&0xFF)<<16)|(color&0xFF00)|((color>>16)&0xFF);
 				}
 				BITMAPINFO bi={0};
 				bi.bmiHeader.biSize=sizeof(BITMAPINFOHEADER);
@@ -2842,7 +2844,7 @@ static void InitStartMenuDLL( void )
 	if (GetWinVersion()<=WIN_VER_WIN81)
 		g_DrawThemeBackgroundHook=SetIatHook(GetModuleHandle(NULL),"uxtheme.dll","DrawThemeBackground",DrawThemeBackground2);
 	g_DrawThemeTextHook=SetIatHook(GetModuleHandle(NULL),"uxtheme.dll","DrawThemeText",DrawThemeText2);
-	g_DrawThemeTextExHook=SetIatHook(GetModuleHandle(NULL),"uxtheme.dll","DrawThemeTextEx",DrawThemeTextEx2);
+	//g_DrawThemeTextExHook=SetIatHook(GetModuleHandle(NULL),"uxtheme.dll","DrawThemeTextEx",DrawThemeTextEx2);
 	g_DrawThemeTextCtlHook=SetIatHook(GetModuleHandle(L"comctl32.dll"),"uxtheme.dll","DrawThemeText",DrawThemeText2);
 	if (GetWinVersion()>=WIN_VER_WIN10)
 		g_SetWindowCompositionAttributeHook=SetIatHook(GetModuleHandle(NULL),"user32.dll","SetWindowCompositionAttribute",SetWindowCompositionAttribute2);

[ge0rdi]

I believe PR #1642 proposed these changes.
There was a review, changes were requested, author admitted the PR is not in mergeable state but then nothing happened.

@Anixx You have commented on that PR, so you should be aware of this.

I personally won't merge such random changes just because they work for some users (and may break many others).
So either someone explains why those changes won't break things (commented code was there for some reason) or they propose better changes that won't break anything.

[Anixx]

We can apply all the changes if IsAppThemed() is false. Would it remove all issues?

[ge0rdi]

Yes, that sounds like a good way to distinguish normal and classic explorer style.
It shouldn't break modern systems (as those have themed explorer).

Basically the change in UpdateTaskBars should be done just for non-themed explorer.
Also the uxtheme hooking is most likely useless in case on non-themed explorer.
The rest is rather fine.

It will be great if @OrthodoxWindows can do that in his PR #1642.
Eventually someone else could create new PR.

And eventually eventually, I can have a look in few days. Though I cannot promise anything (as this thing is really not important to me).

[Anixx]

Done: #2369

[Neustradamus]

@Anixx: Thanks for your work on it!

[OrthodoxWindows]

@Anixx Thank you very much for your work. It will now be easier for any beginner user to use the classic theme!