From 99a78c6561671b1c2816a9ffc1a481459c8afe81 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Mon, 27 Jul 2026 00:46:58 +0900 Subject: [PATCH] test(lit-query): assert exact values instead of loose matchers --- packages/lit-query/src/tests/counters-and-state.test.ts | 5 +++-- packages/lit-query/src/tests/infinite-and-options.test.ts | 5 +++-- packages/lit-query/src/tests/queries-controller.test.ts | 5 +++-- packages/lit-query/src/tests/query-controller.test.ts | 8 ++++---- 4 files changed, 13 insertions(+), 10 deletions(-) diff --git a/packages/lit-query/src/tests/counters-and-state.test.ts b/packages/lit-query/src/tests/counters-and-state.test.ts index d2b14739f4a..e81baa5a751 100644 --- a/packages/lit-query/src/tests/counters-and-state.test.ts +++ b/packages/lit-query/src/tests/counters-and-state.test.ts @@ -272,8 +272,9 @@ describe('useIsFetching/useIsMutating/useMutationState', () => { await waitFor(() => consumer.isMutating() === 0) expect( - explicitClient.getQueryCache().find({ queryKey: consumer.queryKey }), - ).toBeDefined() + explicitClient.getQueryCache().find({ queryKey: consumer.queryKey }) + ?.state.data, + ).toBe('query-ok') expect( providerClient.getQueryCache().find({ queryKey: consumer.queryKey }), ).toBeUndefined() diff --git a/packages/lit-query/src/tests/infinite-and-options.test.ts b/packages/lit-query/src/tests/infinite-and-options.test.ts index 701ea5e34c4..85b7022231e 100644 --- a/packages/lit-query/src/tests/infinite-and-options.test.ts +++ b/packages/lit-query/src/tests/infinite-and-options.test.ts @@ -118,8 +118,9 @@ describe('createInfiniteQueryController', () => { await waitFor(() => consumer.infinite().isSuccess) expect(consumer.infinite().data?.pages).toEqual([0]) expect( - explicitClient.getQueryCache().find({ queryKey: consumer.queryKey }), - ).toBeDefined() + explicitClient.getQueryCache().find({ queryKey: consumer.queryKey }) + ?.state.data, + ).toEqual({ pages: [0], pageParams: [0] }) expect( providerClient.getQueryCache().find({ queryKey: consumer.queryKey }), ).toBeUndefined() diff --git a/packages/lit-query/src/tests/queries-controller.test.ts b/packages/lit-query/src/tests/queries-controller.test.ts index 67f6c5456bb..f651b2b42a8 100644 --- a/packages/lit-query/src/tests/queries-controller.test.ts +++ b/packages/lit-query/src/tests/queries-controller.test.ts @@ -179,8 +179,9 @@ describe('createQueriesController', () => { ) expect( - explicitClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! }), - ).toBeDefined() + explicitClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! }) + ?.state.data, + ).toBe('alpha') expect( providerClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! }), ).toBeUndefined() diff --git a/packages/lit-query/src/tests/query-controller.test.ts b/packages/lit-query/src/tests/query-controller.test.ts index d8261e585c9..43e0bfb4055 100644 --- a/packages/lit-query/src/tests/query-controller.test.ts +++ b/packages/lit-query/src/tests/query-controller.test.ts @@ -1154,7 +1154,7 @@ describe('createQueryController', () => { await waitFor(() => query().isSuccess) const cacheQuery = client.getQueryCache().find({ queryKey }) - expect(cacheQuery).toBeDefined() + expect(cacheQuery?.state.data).toEqual(['a', 'b']) expect(cacheQuery?.getObserversCount()).toBe(1) host.disconnect() @@ -1196,8 +1196,8 @@ describe('createQueryController', () => { await consumer.updateComplete await waitFor(() => consumer.query().isSuccess) - expect(consumer.query().data).toBeDefined() - expect(consumer.queryCalls).toBeGreaterThan(0) + expect(consumer.queryCalls).toBe(1) + expect(consumer.query().data).toBe('value-1') consumer.query.destroy() provider.remove() @@ -1232,7 +1232,7 @@ describe('createQueryController', () => { await consumer.updateComplete await waitFor(() => consumer.query().isSuccess) - expect(consumer.query().data).toBeDefined() + expect(consumer.query().data).toBe('value-1') consumer.query.destroy() provider.remove()