From 05d98500c1ec20a1d51847b7501187cc2b671398 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Mon, 27 Jul 2026 00:47:26 +0900 Subject: [PATCH] test({react,preact}-query): assert exact values instead of loose matchers --- .../src/__tests__/QueryClientProvider.test.tsx | 11 +++++------ .../src/__tests__/mutationOptions.test.tsx | 1 - .../src/__tests__/useSuspenseQuery.test.tsx | 2 +- .../src/__tests__/QueryClientProvider.test.tsx | 11 +++++------ .../src/__tests__/mutationOptions.test.tsx | 1 - .../src/__tests__/useSuspenseQuery.test.tsx | 2 +- 6 files changed, 12 insertions(+), 16 deletions(-) diff --git a/packages/preact-query/src/__tests__/QueryClientProvider.test.tsx b/packages/preact-query/src/__tests__/QueryClientProvider.test.tsx index c6ba18d989a..010d3f7e24e 100644 --- a/packages/preact-query/src/__tests__/QueryClientProvider.test.tsx +++ b/packages/preact-query/src/__tests__/QueryClientProvider.test.tsx @@ -47,7 +47,7 @@ describe('QueryClientProvider', () => { await vi.advanceTimersByTimeAsync(11) expect(rendered.getByText('test')).toBeInTheDocument() - expect(queryCache.find({ queryKey: key })).toBeDefined() + expect(queryCache.find({ queryKey: key })?.state.data).toBe('test') }) it('allows multiple caches to be partitioned', async () => { @@ -100,10 +100,10 @@ describe('QueryClientProvider', () => { expect(rendered.getByText('test1')).toBeInTheDocument() expect(rendered.getByText('test2')).toBeInTheDocument() - expect(queryCache1.find({ queryKey: key1 })).toBeDefined() - expect(queryCache1.find({ queryKey: key2 })).not.toBeDefined() - expect(queryCache2.find({ queryKey: key1 })).not.toBeDefined() - expect(queryCache2.find({ queryKey: key2 })).toBeDefined() + expect(queryCache1.find({ queryKey: key1 })?.state.data).toBe('test1') + expect(queryCache1.find({ queryKey: key2 })).toBeUndefined() + expect(queryCache2.find({ queryKey: key1 })).toBeUndefined() + expect(queryCache2.find({ queryKey: key2 })?.state.data).toBe('test2') }) it("uses defaultOptions for queries when they don't provide their own config", async () => { @@ -141,7 +141,6 @@ describe('QueryClientProvider', () => { await vi.advanceTimersByTimeAsync(11) expect(rendered.getByText('test')).toBeInTheDocument() - expect(queryCache.find({ queryKey: key })).toBeDefined() expect(queryCache.find({ queryKey: key })?.options.gcTime).toBe(Infinity) }) diff --git a/packages/preact-query/src/__tests__/mutationOptions.test.tsx b/packages/preact-query/src/__tests__/mutationOptions.test.tsx index 8b3864b4688..5972fc4d357 100644 --- a/packages/preact-query/src/__tests__/mutationOptions.test.tsx +++ b/packages/preact-query/src/__tests__/mutationOptions.test.tsx @@ -532,6 +532,5 @@ describe('mutationOptions', () => { await vi.advanceTimersByTimeAsync(11) expect(mutationStateArray.length).toEqual(1) expect(mutationStateArray[0]?.data).toEqual('data1') - expect(mutationStateArray[1]).toBeFalsy() }) }) diff --git a/packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx b/packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx index 8ea07b85252..8397312bb60 100644 --- a/packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx +++ b/packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx @@ -206,7 +206,7 @@ describe('useSuspenseQuery', () => { expect(rendered.queryByText('loading')).not.toBeInTheDocument() expect(rendered.queryByText('rendered')).not.toBeInTheDocument() - expect(queryCache.find({ queryKey: key })).toBeFalsy() + expect(queryCache.find({ queryKey: key })).toBeUndefined() fireEvent.click(rendered.getByLabelText('toggle')) expect(rendered.getByText('loading')).toBeInTheDocument() diff --git a/packages/react-query/src/__tests__/QueryClientProvider.test.tsx b/packages/react-query/src/__tests__/QueryClientProvider.test.tsx index 71f80595680..9488d356a7c 100644 --- a/packages/react-query/src/__tests__/QueryClientProvider.test.tsx +++ b/packages/react-query/src/__tests__/QueryClientProvider.test.tsx @@ -46,7 +46,7 @@ describe('QueryClientProvider', () => { await vi.advanceTimersByTimeAsync(11) expect(rendered.getByText('test')).toBeInTheDocument() - expect(queryCache.find({ queryKey: key })).toBeDefined() + expect(queryCache.find({ queryKey: key })?.state.data).toBe('test') }) it('allows multiple caches to be partitioned', async () => { @@ -99,10 +99,10 @@ describe('QueryClientProvider', () => { expect(rendered.getByText('test1')).toBeInTheDocument() expect(rendered.getByText('test2')).toBeInTheDocument() - expect(queryCache1.find({ queryKey: key1 })).toBeDefined() - expect(queryCache1.find({ queryKey: key2 })).not.toBeDefined() - expect(queryCache2.find({ queryKey: key1 })).not.toBeDefined() - expect(queryCache2.find({ queryKey: key2 })).toBeDefined() + expect(queryCache1.find({ queryKey: key1 })?.state.data).toBe('test1') + expect(queryCache1.find({ queryKey: key2 })).toBeUndefined() + expect(queryCache2.find({ queryKey: key1 })).toBeUndefined() + expect(queryCache2.find({ queryKey: key2 })?.state.data).toBe('test2') }) it("uses defaultOptions for queries when they don't provide their own config", async () => { @@ -140,7 +140,6 @@ describe('QueryClientProvider', () => { await vi.advanceTimersByTimeAsync(11) expect(rendered.getByText('test')).toBeInTheDocument() - expect(queryCache.find({ queryKey: key })).toBeDefined() expect(queryCache.find({ queryKey: key })?.options.gcTime).toBe(Infinity) }) diff --git a/packages/react-query/src/__tests__/mutationOptions.test.tsx b/packages/react-query/src/__tests__/mutationOptions.test.tsx index 45129a398d0..7d0b034812c 100644 --- a/packages/react-query/src/__tests__/mutationOptions.test.tsx +++ b/packages/react-query/src/__tests__/mutationOptions.test.tsx @@ -522,6 +522,5 @@ describe('mutationOptions', () => { await vi.advanceTimersByTimeAsync(11) expect(mutationStateArray.length).toEqual(1) expect(mutationStateArray[0]?.data).toEqual('data1') - expect(mutationStateArray[1]).toBeFalsy() }) }) diff --git a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx index bb83983bef3..4a7df3a2a62 100644 --- a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx +++ b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx @@ -192,7 +192,7 @@ describe('useSuspenseQuery', () => { expect(rendered.queryByText('loading')).not.toBeInTheDocument() expect(rendered.queryByText('rendered')).not.toBeInTheDocument() - expect(queryCache.find({ queryKey: key })).toBeFalsy() + expect(queryCache.find({ queryKey: key })).toBeUndefined() fireEvent.click(rendered.getByLabelText('toggle')) expect(rendered.getByText('loading')).toBeInTheDocument()