From 359e6650fc5b7102969d9df49ae8eff596f3b877 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Valentin=20Breu=C3=9F?= <vbreuss@gmail.com>
Date: Fri, 31 Jul 2026 20:15:44 +0200
Subject: [PATCH] chore: stop installing the .NET 8 SDK where nothing runs on
 it

Every CI job installed both 8.0.x and 10.0.x. Only two of them need the .NET 8 runtime: `unit-tests` and `static-code-analysis`, which both run the net8.0 leg of the multi-targeted test projects through `CodeCoverage`. Those keep it.

The rest never execute net8.0 code. `api-tests` runs `Awaiten.Api.Tests`, which targets net10.0 only; `benchmarks` runs a net10.0-only project; `aot-sample` publishes net10.0 natively; `web-sample` runs a net10.0-only app; `pack` builds every target framework but runs none of them, and building net8.0 needs only its reference pack, which restore supplies.

The GitVersion tool does not need it either, which is the part that looks like it should. Nuke runs `gitversion.dll` from the tool's `tools/net8.0` folder, but its runtimeconfig sets `rollForward: LatestMajor`, so the host starts it on whatever runtime is present. `publish-benchmark-report` has been running that way with only 10.0.x for some time, which is the standing proof.

So no change to the GitVersion pin or its `Framework`. Retargeting it to net10.0 would have required bumping the tool from 6.0.5 to 6.8.2, an eight-minor jump in the component that computes published package versions, in exchange for nothing.
---
 .github/workflows/build.yml | 5 -----
 .github/workflows/ci.yml    | 4 ----
 2 files changed, 9 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index f414d5b..9624d1c 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -51,7 +51,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: API checks
                 run: ./build.sh ApiChecks
@@ -86,7 +85,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: Run benchmarks
                 run: ./build.sh Benchmarks --benchmark-filter "*${{ matrix.benchmark }}*"
@@ -137,7 +135,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: Publish and run the native-AOT sample
                 run: ./build.ps1 AotSample
@@ -155,7 +152,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: Run the web sample's smoke test
                 run: ./build.sh WebSample
@@ -212,7 +208,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: Pack nuget packages
                 run: ./build.sh Pack
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c30f177..c199b9d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -50,7 +50,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: API checks
                 run: ./build.sh ApiChecks
@@ -83,7 +82,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: Run benchmarks
                 run: ./build.sh Benchmarks --benchmark-filter "*${{ matrix.benchmark }}*"
@@ -109,7 +107,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: Publish and run the native-AOT sample
                 run: ./build.ps1 AotSample
@@ -127,7 +124,6 @@ jobs:
                 uses: actions/setup-dotnet@v6
                 with:
                     dotnet-version: |
-                        8.0.x
                         10.0.x
             -   name: Run the web sample's smoke test
                 run: ./build.sh WebSample