fix(apigateway): update Response class to require status_code only#1560
Merged
heitorlessa merged 3 commits intoSep 30, 2022
Merged
Conversation
* develop: chore(deps-dev): bump mypy-boto3-secretsmanager from 1.24.54 to 1.24.83 (aws-powertools#1557) chore(layers): add dummy v2 layer automation
Contributor
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
heitorlessa
marked this pull request as ready for review
September 30, 2022 13:28
heitorlessa
requested review from
rubenfonseca
and removed request for
a team
September 30, 2022 13:28
Codecov ReportBase: 99.73% // Head: 99.73% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1560 +/- ##
========================================
Coverage 99.73% 99.73%
========================================
Files 124 124
Lines 5718 5718
Branches 651 651
========================================
Hits 5703 5703
Misses 8 8
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
heitorlessa
requested review from
leandrodamascena
and removed request for
rubenfonseca
September 30, 2022 13:29
rubenfonseca
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #1559
Summary
Changes
Honours docstring by making
content_typeandbodyparameters as optional since they already support defaults when built.User experience
Before
After
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.