Skip to content

fix(changesets): rename stale @cipherstash/cli key to stash#404

Merged
calvinbrewer merged 1 commit into
mainfrom
fix-changeset-cli-package-name
May 4, 2026
Merged

fix(changesets): rename stale @cipherstash/cli key to stash#404
calvinbrewer merged 1 commit into
mainfrom
fix-changeset-cli-package-name

Conversation

@calvinbrewer

Copy link
Copy Markdown
Contributor

Summary

  • The CLI package was renamed @cipherstash/clistash in packages/cli/package.json, but two changesets on main still reference the old name.
  • This breaks the changesets/version action on every push to main:
    Found changeset cli-runner-aware-help-banners for package @cipherstash/cli which is not in the workspace
    
  • Renames the frontmatter package key in both files. Body copy that mentions @cipherstash/cli historically is left intact — changesets only validates frontmatter.

Files touched:

  • .changeset/cli-runner-aware-help-banners.md
  • .changeset/package-manager-aware-output.md

Test plan

  • Confirm changesets/version action succeeds once merged (next push to main).

🤖 Generated with Claude Code

The CLI package was renamed from `@cipherstash/cli` to `stash` in
packages/cli/package.json, but two changesets still referenced the
old name. The changesets/version action on main fails with:

  Found changeset cli-runner-aware-help-banners for package
  @cipherstash/cli which is not in the workspace

Updates both frontmatter keys to the current package name. Body copy
that mentions `@cipherstash/cli` historically is left intact —
changesets only validates the YAML frontmatter package keys.
@calvinbrewer
calvinbrewer requested a review from a team as a code owner May 4, 2026 16:54
@changeset-bot

changeset-bot Bot commented May 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 71e737f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 6 packages
Name Type
stash Patch
@cipherstash/wizard Patch
@cipherstash/protect Patch
@cipherstash/drizzle Patch
@cipherstash/e2e Patch
@cipherstash/protect-dynamodb Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@calvinbrewer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 47 minutes and 27 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 38b7f77c-5092-4611-acfb-06d97eb2dc9b

📥 Commits

Reviewing files that changed from the base of the PR and between 3627535 and 71e737f.

📒 Files selected for processing (2)
  • .changeset/cli-runner-aware-help-banners.md
  • .changeset/package-manager-aware-output.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-changeset-cli-package-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 47 minutes and 27 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@calvinbrewer
calvinbrewer merged commit d732f27 into main May 4, 2026
7 checks passed
@calvinbrewer
calvinbrewer deleted the fix-changeset-cli-package-name branch May 4, 2026 16:57
coderdan added a commit that referenced this pull request Jul 15, 2026
The ciphertext-free approach was non-functional: encryptQuery can't mint a
scalar/ordering query term against a ste_vec (JSON) column, so the value call
threw "Index type not configured" (caught by CI's live integration job).

Verified via FFI probes: the stored ste_vec entry at the JSONPath selector
carries c + op (ordering) / hm (equality), and encryptQuery('$.path') returns
the selector that matches it. So the RHS is a STORAGE encryption of {path: value}
whose entry is extracted with jsonb_path_query_first and compared entry-vs-entry
(eq_term/ord_term read only hm/op). Ciphertext-free ordering needs a protect-ffi
change (cipherstash/protectjs-ffi#137); until then the value's ciphertext is in
the WHERE clause — documented inline.

Also from the code review: use Promise.all for the two independent encrypts;
throw (not silently mis-bind) if the selector term isn't a bare string; fix path
normalization (leading $/.) and reject the empty/root path; drop the fragile
JS-type→query-domain inference entirely.

Refs #623 · protect-ffi gap cipherstash/protectjs-ffi#137 · EQL operator #404
Claude-Session: https://claude.ai/code/session_01MxTTPaPP16m6br7Hoab94w
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant