Added user_roles migration, model, endpoint.

Also added a tag to add to all endpoints that require secret env variables be ignored in tests by default.

To run all tests, including those which interface with secret env vars, run 'mix test --include requires_env'

Also added user_role_view_test, user_view_test, and preloaded roles
relationship on all user endpoints.

Endpoint issue: #40
Contributes to #109 (exclude tests that rely on ENV vars)

Author: green-arrow

priv/repo/migrations/20160822011624_create_user_role.exs

@@ -0,0 +1,14 @@
+defmodule CodeCorps.Repo.Migrations.CreateUserRole do
+  use Ecto.Migration
+
+  def change do
+    create table(:user_roles) do
+      add :user_id, references(:users, on_delete: :nothing)
+      add :role_id, references(:roles, on_delete: :nothing)
+
+      timestamps()
+    end
+
+    create index(:user_roles, [:user_id, :role_id], unique: true)
+  end
+end

test/controllers/organization_controller_test.exs

@@ -74,6 +74,7 @@ defmodule CodeCorps.OrganizationControllerTest do
     assert organization.id == slugged_route.organization_id
   end
 
+  @tag :requires_env
   test "uploads a icon to S3", %{conn: conn} do
     organization = insert_organization()
     icon_data = "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs="

test/controllers/project_controller_test.exs

@@ -133,6 +133,7 @@ defmodule CodeCorps.ProjectControllerTest do
       assert project.organization_id == organization.id
     end
 
+    @tag :requires_env
     test "uploads a icon to S3", %{conn: conn} do
       project = insert_project()
       icon_data = "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs="

test/controllers/user_controller_test.exs

@@ -126,6 +126,7 @@ defmodule CodeCorps.UserControllerTest do
       assert user.biography == "Just a test user"
     end
 
+    @tag :requires_env
     test "uploads a photo to S3", %{conn: conn} do
       user = insert_user()
       photo_data = "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs="

test/controllers/user_role_controller_test.exs

@@ -0,0 +1,71 @@
+defmodule CodeCorps.UserRoleControllerTest do
+  use CodeCorps.ConnCase
+
+  alias CodeCorps.UserRole
+  alias CodeCorps.Repo
+
+  setup do
+    conn =
+      %{build_conn | host: "api."}
+      |> put_req_header("accept", "application/vnd.api+json")
+      |> put_req_header("content-type", "application/vnd.api+json")
+
+    {:ok, conn: conn}
+  end
+
+  defp attributes do
+    %{}
+  end
+
+  defp relationships(user, role) do
+    %{
+      user: %{data: %{id: user.id}},
+      role: %{data: %{id: role.id}}
+    }
+  end
+
+  test "creates and renders resource when data is valid", %{conn: conn} do
+    user = insert_user(%{email: "test-user@mail.com"})
+    role = insert_role(%{title: "test-role"})
+
+    conn = post conn, user_role_path(conn, :create), %{
+      "meta" => %{},
+      "data" => %{
+        "type" => "user-role",
+        "attributes" => attributes,
+        "relationships" => relationships(user, role)
+      }
+    }
+
+    json = json_response(conn, 201)
+
+    id = json["data"]["id"] |> String.to_integer
+    user_role = UserRole |> Repo.get!(id)
+
+    assert json["data"]["id"] == "#{user_role.id}"
+    assert json["data"]["type"] == "user-role"
+    assert json["data"]["relationships"]["user"]["data"]["id"] == "#{user.id}"
+    assert json["data"]["relationships"]["role"]["data"]["id"] == "#{role.id}"
+  end
+
+  test "does not create resource and renders errors when data is invalid", %{conn: conn} do
+    conn = post conn, user_role_path(conn, :create), %{
+      "meta" => %{},
+      "data" => %{
+        "type" => "user-role",
+        "attributes" => attributes,
+      }
+    }
+
+    assert json_response(conn, 422)["errors"] != %{}
+  end
+
+  test "deletes resource", %{conn: conn} do
+    role = insert_role(%{title: "test-role"})
+    user = insert_user(%{email: "test-user@mail.com"})
+    user_role = insert_user_role(%{user_id: user.id, role_id: role.id})
+    response = delete conn, user_role_path(conn, :delete, user_role)
+
+    assert response.status == 204
+  end
+end

test/models/organization_test.exs

@@ -16,6 +16,7 @@ defmodule CodeCorps.OrganizationTest do
     refute changeset.valid?
   end
 
+  @tag :requires_env
   test "uploads base64icon data to aws" do
     # 1x1 black pixel gif
     icon_data = "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs="

test/models/project_test.exs

@@ -39,6 +39,7 @@ defmodule CodeCorps.ProjectTest do
     refute changeset.valid?
   end
 
+  @tag :requires_env
   test "uploads base64icon data to aws" do
     # 1x1 black pixel gif
     icon_data = "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs="

test/models/user_role_test.exs

@@ -0,0 +1,57 @@
+defmodule CodeCorps.UserRoleTest do
+  use CodeCorps.ModelCase
+
+  alias CodeCorps.UserRole
+
+  test "valid_changeset_is_valid" do
+    user_id = insert_user().id
+    role_id = insert_role().id
+
+    changeset = UserRole.changeset(%UserRole{}, %{user_id: user_id, role_id: role_id})
+    assert changeset.valid?
+  end
+
+  test "changeset requires user_id" do
+    role_id = insert_role().id
+
+    changeset = UserRole.changeset(%UserRole{}, %{role_id: role_id})
+
+    refute changeset.valid?
+    assert changeset.errors[:user_id] == {"can't be blank", []}
+  end
+
+  test "changeset requires role_id" do
+    user_id = insert_user().id
+
+    changeset = UserRole.changeset(%UserRole{}, %{user_id: user_id})
+
+    refute changeset.valid?
+    assert changeset.errors[:role_id] == {"can't be blank", []}
+  end
+
+  test "changeset requires id of actual user" do
+    user_id = -1
+    role_id = insert_role().id
+
+    { result, changeset } =
+      UserRole.changeset(%UserRole{}, %{user_id: user_id, role_id: role_id})
+      |> Repo.insert
+
+    assert result == :error
+    refute changeset.valid?
+    assert changeset.errors[:user] == {"does not exist", []}
+  end
+
+  test "changeset requires id of actual role" do
+    user_id = insert_user().id
+    role_id = -1
+
+    { result, changeset } =
+      UserRole.changeset(%UserRole{}, %{user_id: user_id, role_id: role_id})
+      |> Repo.insert
+
+    assert result == :error
+    refute changeset.valid?
+    assert changeset.errors[:role] == {"does not exist", []}
+  end
+end

test/models/user_test.exs

@@ -98,6 +98,7 @@ defmodule CodeCorps.UserTest do
       refute Map.has_key?(changeset.changes, :website)
     end
 
+    @tag :requires_env
     test "uploads base64photo data to aws" do
       # 1x1 black pixel gif
       photo_data = "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs="

test/support/factories.ex

@@ -10,6 +10,21 @@ defmodule CodeCorps.Factories do
     }
   end
 
+  def user_role_factory do
+    %CodeCorps.UserRole{
+      user: build(:user),
+      role: build(:role)
+    }
+  end
+
+  def role_factory do
+    %CodeCorps.Role{
+      name: sequence(:name, &"Role #{&1}"),
+      ability: sequence(:ability, &"Ability for role #{&1}"),
+      kind: sequence(:kind, &"Kind for role #{&1}")
+    }
+  end
+
   def organization_factory do
     %CodeCorps.Organization{
       name: sequence(:username, &"Organization #{&1}"),