Skip to content

docker 1.8+ no longer needs dind - #15596

Merged
jessfraz merged 1 commit into
moby:masterfrom
jessfraz:hack-dind-its-been-fun
Aug 21, 2015
Merged

docker 1.8+ no longer needs dind#15596
jessfraz merged 1 commit into
moby:masterfrom
jessfraz:hack-dind-its-been-fun

Conversation

@jessfraz

Copy link
Copy Markdown
Contributor

ping @tianon idk what to make the entrypoint tbh or if you think this is too soon ;)

@jessfraz

Copy link
Copy Markdown
Contributor Author

hmm weird errors... need to investigate why...

@jessfraz

Copy link
Copy Markdown
Contributor Author

the windows side is because i need to update those servers

@thaJeztah

Copy link
Copy Markdown
Member

@tianon

tianon commented Aug 21, 2015

Copy link
Copy Markdown
Member

Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed.

IMO we should still keep the entrypoint around for a while since it'll still be needed on older Docker versions, but making it do the mounting nonsense conditionally based on whether we've already got it all mounted seems really sane. 👍 (ie, if ! mountpoint -q /sys/fs/cgroup; then ...)

@jessfraz

Copy link
Copy Markdown
Contributor Author

nice yeah

On Fri, Aug 21, 2015 at 10:23 AM, Tianon Gravi notifications@github.com
wrote:

Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed.

IMO we should still keep the entrypoint around for a while since it'll
still be needed on older Docker versions, but making it do the mounting
nonsense conditionally based on whether we've already got it all mounted
seems really sane. [image: 👍](ie, if ! mountpoint -q /sys/fs/cgroup;
then ...)


Reply to this email directly or view it on GitHub
#15596 (comment).

Signed-off-by: Jessica Frazelle <acidburn@docker.com>
@jessfraz
jessfraz force-pushed the hack-dind-its-been-fun branch from 8145137 to c48ac77 Compare August 21, 2015 18:13
@tianon

tianon commented Aug 21, 2015

Copy link
Copy Markdown
Member

LGTM 🤘

@tianon

tianon commented Aug 21, 2015

Copy link
Copy Markdown
Member

(much easier to review via https://github.com/docker/docker/pull/15596/files?w=1 now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants