[bot] Merge master/5684211c into rel/dev#1695
Conversation
…turn evaluators metric_skill and alert_skill evaluators already parse the create_metric / create_metric_alert tool call's result to grade the run, but discarded the real server-assigned id. Downstream consumers running these single-turn evals against a shared workspace (e.g. a CI orchestrator) currently have no way to know exactly what was created, and have to diff the workspace catalog before/after to guess at cleanup -- fragile under concurrent activity. Surface the id gd-eval already has in memory instead.
result_data["data"] being present but not a dict (malformed/unexpected
tool-result payload) crashed with AttributeError on .get("id") instead of
reporting automation_id=None like the rest of the function already does
for other malformed shapes.
Addresses CodeRabbit review comment on #1694.
feat(gooddata-eval): report created metric/automation id from single-turn evaluators
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1695 +/- ##
========================================
Coverage 78.05% 78.05%
========================================
Files 271 271
Lines 18669 18676 +7
========================================
+ Hits 14572 14578 +6
- Misses 4097 4098 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
🚀 Automated PR to perform merge from master into rel/dev with changes up to 5684211 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/29989858238).