feat(agentidentity): onboard v1 and v1beta clients#17740
Conversation
![gemini-code-assist[bot]](https://cdn.github.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the google-cloud-agentidentity client library, including support for both v1 and v1beta versions. The review identified several issues: the copyright year in librarian.yaml is set to a future date (2026), the API enablement links in the README files should point to the direct console URL, the documentation index has a duplicated heading, and the example workload identity in the type definitions refers to an incorrect service (aiplatform).
| apis: | ||
| - path: google/cloud/agentidentity/v1 | ||
| - path: google/cloud/agentidentity/v1beta | ||
| copyright_year: "2026" |
There was a problem hiding this comment.
The copyright year is set to 2026, which is in the future. This appears to be a typo and should be updated to the current year.
|
|
||
| .. _Select or create a Cloud Platform project.: https://console.cloud.google.com/project | ||
| .. _Enable billing for your project.: https://cloud.google.com/billing/docs/how-to/modify-project#enable_billing_for_a_project | ||
| .. _Enable the Agent Identity.: https://cloud.google.com/agentidentity/ |
There was a problem hiding this comment.
The link to enable the API points to the general product documentation. For a better user experience, it should point directly to the API enablement page in the Cloud Console.
| .. _Enable the Agent Identity.: https://cloud.google.com/agentidentity/ | |
| .. _Enable the Agent Identity.: https://console.cloud.google.com/flows/enableapi?apiid=agentidentity.googleapis.com |
|
|
||
| .. _Select or create a Cloud Platform project.: https://console.cloud.google.com/project | ||
| .. _Enable billing for your project.: https://cloud.google.com/billing/docs/how-to/modify-project#enable_billing_for_a_project | ||
| .. _Enable the Agent Identity.: https://cloud.google.com/agentidentity/ |
There was a problem hiding this comment.
The link to enable the API points to the general product documentation. For a better user experience, it should point directly to the API enablement page in the Cloud Console.
| .. _Enable the Agent Identity.: https://cloud.google.com/agentidentity/ | |
| .. _Enable the Agent Identity.: https://console.cloud.google.com/flows/enableapi?apiid=agentidentity.googleapis.com |
| API Reference | ||
| ------------- |
There was a problem hiding this comment.
The "API Reference" heading is duplicated. It would be clearer to have a single main heading and then use subheadings for each API version (e.g., v1 and v1beta).
| Optional. Input only. Represents the workload identity in | ||
| IAM ``principal://`` format of the agent(s) that will use | ||
| this AuthProvider. Example: | ||
| ``principal://agents.global.org-${ORG_ID}.system.id.goog/resources/aiplatform/projects/{PROJECT_ID}/locations/{LOCATIONS}/reasoningEngines/{ID}`` |
There was a problem hiding this comment.
The example workload identity appears to be for a different service (aiplatform/reasoningEngines). To avoid confusion, please consider updating it to a more generic example or one specific to Agent Identity.
| Optional. Input only. Represents the workload identity in | ||
| IAM ``principal://`` format of the agent(s) that will use | ||
| this AuthProvider. Example: | ||
| ``principal://agents.global.org-${ORG_ID}.system.id.goog/resources/aiplatform/projects/{PROJECT_ID}/locations/{LOCATIONS}/reasoningEngines/{ID}`` |
There was a problem hiding this comment.
The example workload identity appears to be for a different service (aiplatform/reasoningEngines). To avoid confusion, please consider updating it to a more generic example or one specific to Agent Identity.
noahdietz
added
the
do not merge
|
Holding for the bulk release to go out first |
noahdietz
removed
the
do not merge
🤖 I have created a release *beep* *boop* --- <details><summary>google-cloud-agentidentity: 0.1.0</summary> ## 0.1.0 (2026-07-16) ### Features * **agentidentity:** onboard v1 and v1beta clients ([#17740](#17740)) ([9eead95](9eead95)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
2 participants
Onboard the
v1andv1betaAPI versions of the Agent Identity API.Internal intake bugs http://b/534344011 http://b/533456597