From 48eb210319e015137151113183651d5cb85e9925 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 24 Jul 2026 08:53:10 +0000 Subject: [PATCH] test: dedupe isDefined helper against the library util The live-query test helper (src/tests/liveQuery.tsx) defined its own `isDefined` type-guard, a runtime-identical copy of the shipped `src/lib/utils/isDefined.ts`. Import the library util directly in the two live-query test suites and delete the local copy, so there is one implementation instead of two. Behavior-preserving: the query pipes and assertions are unchanged; only the source of `isDefined` moved. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01PMgtP4GREPoEq9LdTBcHky --- src/lib/queries/useQuery$.reactivity.test.tsx | 2 +- src/lib/queries/useQuery$.unmount.test.tsx | 2 +- src/tests/liveQuery.tsx | 4 ---- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/lib/queries/useQuery$.reactivity.test.tsx b/src/lib/queries/useQuery$.reactivity.test.tsx index 192dd09..20af7b1 100644 --- a/src/lib/queries/useQuery$.reactivity.test.tsx +++ b/src/lib/queries/useQuery$.reactivity.test.tsx @@ -4,10 +4,10 @@ import { describe, expect, it } from "vitest" import { createQueryClient, createWrapper, - isDefined, liveQueryOptions, } from "../../tests/liveQuery" import { waitForTimeout } from "../../tests/utils" +import { isDefined } from "../utils/isDefined" import { useQuery$ } from "./useQuery$" describe("useQuery$ live-query reactivity", () => { diff --git a/src/lib/queries/useQuery$.unmount.test.tsx b/src/lib/queries/useQuery$.unmount.test.tsx index e553718..d07d9ac 100644 --- a/src/lib/queries/useQuery$.unmount.test.tsx +++ b/src/lib/queries/useQuery$.unmount.test.tsx @@ -5,10 +5,10 @@ import { describe, expect, it } from "vitest" import { createQueryClient, createWrapper, - isDefined, liveQueryOptions, } from "../../tests/liveQuery" import { waitForTimeout } from "../../tests/utils" +import { isDefined } from "../utils/isDefined" import { useQuery$ } from "./useQuery$" describe("useQuery$ unmount / remount", () => { diff --git a/src/tests/liveQuery.tsx b/src/tests/liveQuery.tsx index 51f5e54..5f1b27a 100644 --- a/src/tests/liveQuery.tsx +++ b/src/tests/liveQuery.tsx @@ -2,10 +2,6 @@ import { QueryClient, QueryClientProvider } from "@tanstack/react-query" import type React from "react" import { QueryClientProvider$ } from "../lib/queries/QueryClientProvider$" -export function isDefined(value: T | undefined | null): value is T { - return value != null -} - export function createQueryClient() { return new QueryClient({ defaultOptions: {