addressed copilot comments

Author: bachuv

client/src/main/java/com/microsoft/durabletask/ListInstanceIdsQuery.java

@@ -5,6 +5,7 @@
 import javax.annotation.Nullable;
 import java.time.Instant;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 
 /**
@@ -93,26 +94,46 @@ public ListInstanceIdsQuery setContinuationToken(@Nullable String continuationTo
         return this;
     }
 
-    List<OrchestrationRuntimeStatus> getRuntimeStatusList() {
-        return this.runtimeStatusList;
+    /**
+     * Gets the configured terminal runtime status filter, or an empty list if none was configured.
+     * @return an unmodifiable view of the configured terminal runtime status filter
+     */
+    public List<OrchestrationRuntimeStatus> getRuntimeStatusList() {
+        return Collections.unmodifiableList(this.runtimeStatusList);
     }
 
+    /**
+     * Gets the configured minimum completion time, or {@code null} if none was configured.
+     * @return the configured minimum completion time, or {@code null} if none was configured
+     */
     @Nullable
-    Instant getCompletedTimeFrom() {
+    public Instant getCompletedTimeFrom() {
         return this.completedTimeFrom;
     }
 
+    /**
+     * Gets the configured maximum completion time, or {@code null} if none was configured.
+     * @return the configured maximum completion time, or {@code null} if none was configured
+     */
     @Nullable
-    Instant getCompletedTimeTo() {
+    public Instant getCompletedTimeTo() {
         return this.completedTimeTo;
     }
 
-    int getPageSize() {
+    /**
+     * Gets the configured maximum number of instance IDs to return per page.
+     * @return the configured page size
+     */
+    public int getPageSize() {
         return this.pageSize;
     }
 
+    /**
+     * Gets the configured pagination cursor, or {@code null} if none was configured.
+     * @return the configured pagination cursor, or {@code null} if none was configured
+     */
     @Nullable
-    String getContinuationToken() {
+    public String getContinuationToken() {
         return this.continuationToken;
     }
 }

client/src/main/java/com/microsoft/durabletask/history/OrchestrationState.java

@@ -84,7 +84,7 @@ public OrchestrationState(
         this.failureDetails = failureDetails;
         this.executionId = executionId;
         this.parentInstanceId = parentInstanceId;
-        this.tags = tags == null ? null : Collections.unmodifiableMap(new HashMap<>(tags));
+        this.tags = tags != null ? Collections.unmodifiableMap(new HashMap<>(tags)) : Collections.emptyMap();
     }
 
     /** @return the orchestration instance ID. */
@@ -168,8 +168,7 @@ public String getParentInstanceId() {
         return this.parentInstanceId;
     }
 
-    /** @return an unmodifiable view of the orchestration tags, or {@code null} if not set. */
-    @Nullable
+    /** @return the orchestration tags (never {@code null}; empty when none). */
     public Map<String, String> getTags() {
         return this.tags;
     }

client/src/test/java/com/microsoft/durabletask/IntegrationTests.java

@@ -1320,14 +1320,12 @@ void listInstanceIdsByCompletionWindow() throws TimeoutException {
 
         DurableTaskClient client = this.createClientBuilder().build();
         try (worker; client) {
-            Instant from = Instant.now().minus(Duration.ofMinutes(1));
-
             String instanceId = client.scheduleNewOrchestrationInstance(orchestratorName, 0);
             OrchestrationMetadata metadata = client.waitForInstanceCompletion(instanceId, defaultTimeout, false);
             assertEquals(OrchestrationRuntimeStatus.COMPLETED, metadata.getRuntimeStatus());
 
             ListInstanceIdsResult result = client.listInstanceIds(new ListInstanceIdsQuery()
-                    .setCompletedTimeFrom(from)
+                    .setCompletedTimeFrom(metadata.getCreatedAt())
                     .setRuntimeStatusList(Collections.singletonList(OrchestrationRuntimeStatus.COMPLETED))
                     .setPageSize(100));
 

client/src/test/java/com/microsoft/durabletask/ListInstanceIdsQueryTest.java

@@ -4,6 +4,7 @@
 
 import org.junit.jupiter.api.Test;
 
+import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -43,6 +44,30 @@ void setRuntimeStatusList_copiesInput_soExternalMutationDoesNotAffectQuery() {
         assertEquals(Arrays.asList(OrchestrationRuntimeStatus.COMPLETED), query.getRuntimeStatusList());
     }
 
+    @Test
+    void getRuntimeStatusList_returnsUnmodifiableView() {
+        ListInstanceIdsQuery query = new ListInstanceIdsQuery()
+                .setRuntimeStatusList(Arrays.asList(OrchestrationRuntimeStatus.COMPLETED));
+
+        assertThrows(
+                UnsupportedOperationException.class,
+                () -> query.getRuntimeStatusList().add(OrchestrationRuntimeStatus.FAILED));
+    }
+
+    @Test
+    void getters_returnConfiguredValues() {
+        Instant completedTimeFrom = Instant.parse("2026-01-01T00:00:00Z");
+        Instant completedTimeTo = Instant.parse("2026-01-02T00:00:00Z");
+        ListInstanceIdsQuery query = new ListInstanceIdsQuery()
+                .setCompletedTimeFrom(completedTimeFrom)
+                .setCompletedTimeTo(completedTimeTo)
+                .setContinuationToken("next-page");
+
+        assertEquals(completedTimeFrom, query.getCompletedTimeFrom());
+        assertEquals(completedTimeTo, query.getCompletedTimeTo());
+        assertEquals("next-page", query.getContinuationToken());
+    }
+
     @Test
     void setPageSize_positiveValue_updatesPageSize() {
         ListInstanceIdsQuery query = new ListInstanceIdsQuery().setPageSize(25);

client/src/test/java/com/microsoft/durabletask/history/OrchestrationStateTest.java

@@ -0,0 +1,40 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+package com.microsoft.durabletask.history;
+
+import com.microsoft.durabletask.OrchestrationRuntimeStatus;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Unit tests for {@link OrchestrationState}.
+ */
+public class OrchestrationStateTest {
+
+    @Test
+    void nullTagsNormalizeToEmptyUnmodifiableMap() {
+        OrchestrationState state = new OrchestrationState(
+                "instance-id",
+                "orchestration-name",
+                null,
+                OrchestrationRuntimeStatus.COMPLETED,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null);
+
+        assertNotNull(state.getTags());
+        assertTrue(state.getTags().isEmpty());
+        assertThrows(UnsupportedOperationException.class, () -> state.getTags().put("env", "prod"));
+    }
+}