Skip to content

Fix NcAppNavigationItem docs - #3076

Merged
raimund-schluessler merged 1 commit into
masterfrom
fix/noid/app-navigation-item-docs
Aug 19, 2022
Merged

Fix NcAppNavigationItem docs#3076
raimund-schluessler merged 1 commit into
masterfrom
fix/noid/app-navigation-item-docs

Conversation

@raimund-schluessler

Copy link
Copy Markdown
Contributor

Regression of #3058 where I missed adding the prefix to some components in the docs.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 19, 2022
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component regression Regression of a previous working feature labels Aug 19, 2022
@raimund-schluessler
raimund-schluessler marked this pull request as ready for review August 19, 2022 14:57
@marcoambrosini

marcoambrosini commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

lol 17b0b34

You were 3 mins faster than me. Should I drop that or close this?

@raimund-schluessler

Copy link
Copy Markdown
Contributor Author

lol 17b0b34

You were 3 mins faster than me

Fine with me 😄
I leave it up to you, if you want to merge this separately.

@marcoambrosini

Copy link
Copy Markdown
Contributor

lemme drop that, it's sort of sneaked in there xD

@marcoambrosini

Copy link
Copy Markdown
Contributor

wrong button

@raimund-schluessler
raimund-schluessler merged commit af4c279 into master Aug 19, 2022
@raimund-schluessler
raimund-schluessler deleted the fix/noid/app-navigation-item-docs branch August 19, 2022 17:59
@skjnldsv skjnldsv mentioned this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants