fix(stats): avoid max argument overflow (#44494)

Author: zharinov

lib/util/stats.spec.ts

@@ -50,6 +50,20 @@ describe('util/stats', () => {
         totalMs: 700,
       });
     });
+
+    it('does not overflow the call stack for large datasets', () => {
+      const res = makeTimingReport(
+        Array.from<number>({ length: 200_000 }).fill(1),
+      );
+
+      expect(res).toEqual({
+        avgMs: 1,
+        count: 200_000,
+        maxMs: 1,
+        medianMs: 1,
+        totalMs: 200_000,
+      });
+    });
   });
 
   describe('LookupStats', () => {

lib/util/stats.ts

@@ -17,7 +17,10 @@ export function makeTimingReport(data: number[]): TimingStatsReport {
   const count = data.length;
   const totalMs = data.reduce((a, c) => a + c, 0);
   const avgMs = count ? Math.round(totalMs / count) : 0;
-  const maxMs = Math.max(0, ...data);
+  let maxMs = 0;
+  for (const duration of data) {
+    maxMs = Math.max(maxMs, duration);
+  }
   const sorted = data.sort((a, b) => a - b);
   const medianMs = count ? sorted[Math.floor(count / 2)] : 0;
   return { count, avgMs, medianMs, maxMs, totalMs };