Question about main frame navigation raising Ferrum::StatusError

[francisbeaudoin]

Hello,

I'm wondering if there's context behind only raising a StatusError for a subset of errors when navigating the top frame?

ferrum/lib/ferrum/page.rb

Lines 113 to 124 in 0cab51d

	def go_to(url = nil)
	options = { url: combine_url!(url) }
	options.merge!(referrer: referrer) if referrer
	response = command("Page.navigate", wait: GOTO_WAIT, **options)
	# https://cs.chromium.org/chromium/src/net/base/net_error_list.h
	if %w[net::ERR_NAME_NOT_RESOLVED
	net::ERR_NAME_RESOLUTION_FAILED
	net::ERR_INTERNET_DISCONNECTED
	net::ERR_CONNECTION_TIMED_OUT
	net::ERR_FILE_NOT_FOUND].include?(response["errorText"])
	raise StatusError, options[:url]
	end

Unless mistaken as only these 5 errors are handled, it implies that we need to inspect the network traffic to know whether navigation was successful. Should there be a lot of traffic, that is a bit cumbersome as the network traffic needs to be filtered to properly identify the main frame request (including its redirection) and then finally check if it has a Exchange#error to assess a successful top frame navigation.

[route]

Don't quite understand what are you proposing instead between the lines? What seems to be incorrect now and what the solution is.

[francisbeaudoin]

@route Sorry if that wasn't clear.

I think that a StatusError should be raised if Page.navigate returns an errorText, regardless of the actual error code.

Per the documentation an errorText is present if and only if navigation has failed. Therefore, the proposition is to have something similar:

...
response = command("Page.navigate", wait: GOTO_WAIT, **options)
raise StatusError.new(options[:url], "Request to #{options[:url]} failed (#{response['errorText']}).") if response['errorText']
...

[route]

I see, the reason behind that StatusError is that in cuprite we'd like to show that page cannot be loaded https://github.com/rubycdp/cuprite/blob/7ace9f6292a7f7c4ebb5375077c067a0311cc4f1/spec/features/driver_spec.rb#L636 it stemmed from poltergeist. You are right I suppose and we can raise error in all cases. Mind sending a PR?