ASoC: SOF: ipc4-pcm: Workaround for firmware crash on stream stop

On stream stop there is one place where a firmware crash can break the
state cleanup which will result broken runtime state and prevents further
audio activities and the drivers must be removed and reloaded.

We must not ignore errors from the DSP but if the DSP is in SOF_FW_CRASHED
and the cmd is stop with reset state we should continue the execution on
the kernel side.

All subsequent IPCs will fail (not sent to DSP) but the kernel state will
be torn down to a correct, expected state.

Link: thesofproject/sof#8721
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Author: ujfalusi

sound/soc/sof/ipc4-pcm.c

@@ -413,7 +413,19 @@ static int sof_ipc4_trigger_pipelines(struct snd_soc_component *component,
 	ret = sof_ipc4_set_multi_pipeline_state(sdev, state, trigger_list);
 	if (ret < 0) {
 		dev_err(sdev->dev, "failed to set final state %d for all pipelines\n", state);
-		goto free;
+		/*
+		 * workaround: if the firmware crashes during stop on pipeline
+		 * reset we must continue cleaning up the state by clearing the
+		 * return error code.
+		 * Since the firmware is crashed we will not send IPC messages
+		 * and we are going to see errors printed, but the state of the
+		 * widgets will be correct for the next boot.
+		 */
+		if (sdev->fw_state != SOF_FW_CRASHED ||
+		    !(cmd == SNDRV_PCM_TRIGGER_STOP && state == SOF_IPC4_PIPE_RESET))
+			goto free;
+
+		ret = 0;
 	}
 
 	/* update RUNNING/RESET state for all pipelines that were just triggered */