diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index cc40880bff88a2..3f355cd4b4a0b6 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -980,6 +980,31 @@ static void cdns_update_slave_status_work(struct work_struct *work) } +/* paranoia check to make sure self-cleared bits are indeed cleared */ +void sdw_cdns_check_self_clearing_bits(struct sdw_cdns *cdns, const char *string) +{ + u32 mcp_control; + u32 mcp_config_update; + + mcp_control = cdns_readl(cdns, CDNS_MCP_CONTROL); + + if (mcp_control & CDNS_MCP_CONTROL_CMD_RST) + dev_err(cdns->dev, "%s failed: MCP_CONTROL_CMD_RST is not cleared\n", string); + if (mcp_control & CDNS_MCP_CONTROL_SOFT_RST) + dev_err(cdns->dev, "%s failed: MCP_CONTROL_SOFT_RST is not cleared\n", string); + if (mcp_control & CDNS_MCP_CONTROL_SW_RST) + dev_err(cdns->dev, "%s failed: MCP_CONTROL_SW_RST is not cleared\n", string); + if (mcp_control & CDNS_MCP_CONTROL_HW_RST) + dev_err(cdns->dev, "%s failed: MCP_CONTROL_HW_RST is not cleared\n", string); + if (mcp_control & CDNS_MCP_CONTROL_CLK_STOP_CLR) + dev_err(cdns->dev, "%s failed: MCP_CONTROL_CLK_STOP_CLR is not cleared\n", string); + + mcp_config_update = cdns_readl(cdns, CDNS_MCP_CONFIG_UPDATE); + if (mcp_config_update & CDNS_MCP_CONFIG_UPDATE_BIT) + dev_err(cdns->dev, "%s failed: MCP_CONFIG_UPDATE_BIT is not cleared\n", string); +} +EXPORT_SYMBOL(sdw_cdns_check_self_clearing_bits); + /* * init routines */ @@ -1257,6 +1282,8 @@ int sdw_cdns_init(struct sdw_cdns *cdns) cdns_init_clock_ctrl(cdns); + sdw_cdns_check_self_clearing_bits(cdns, __func__); + /* reset msg_count to default value of FIFOLEVEL */ cdns->msg_count = cdns_readl(cdns, CDNS_MCP_FIFOLEVEL); @@ -1501,6 +1528,8 @@ int sdw_cdns_clock_stop(struct sdw_cdns *cdns, bool block_wake) struct sdw_slave *slave; int ret; + sdw_cdns_check_self_clearing_bits(cdns, __func__); + /* Check suspend status */ if (sdw_cdns_is_clock_stop(cdns)) { dev_dbg(cdns->dev, "Clock is already stopped\n"); diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h index 86d582c54de789..65c89632858dda 100644 --- a/drivers/soundwire/cadence_master.h +++ b/drivers/soundwire/cadence_master.h @@ -190,4 +190,7 @@ int cdns_bus_conf(struct sdw_bus *bus, struct sdw_bus_params *params); int cdns_set_sdw_stream(struct snd_soc_dai *dai, void *stream, bool pcm, int direction); + +void sdw_cdns_check_self_clearing_bits(struct sdw_cdns *cdns, const char *string); + #endif /* __SDW_CADENCE_H */ diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index c11e3d8cd308f1..cfddd9226c5802 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1467,6 +1467,8 @@ int intel_link_startup(struct auxiliary_device *auxdev) goto err_interrupt; } } + usleep_range(1000, 1500); + sdw_cdns_check_self_clearing_bits(cdns, __func__); /* Register DAIs */ ret = intel_register_dai(sdw); @@ -1783,6 +1785,8 @@ static int __maybe_unused intel_resume(struct device *dev) return ret; } } + usleep_range(1000, 1500); + sdw_cdns_check_self_clearing_bits(cdns, __func__); /* * after system resume, the pm_runtime suspend() may kick in @@ -1867,6 +1871,9 @@ static int __maybe_unused intel_resume_runtime(struct device *dev) return ret; } } + usleep_range(1000, 1500); + sdw_cdns_check_self_clearing_bits(cdns, "intel_resume_runtime TEARDOWN"); + } else if (clock_stop_quirks & SDW_INTEL_CLK_STOP_BUS_RESET) { ret = intel_init(sdw); if (ret) { @@ -1940,6 +1947,9 @@ static int __maybe_unused intel_resume_runtime(struct device *dev) } } } + usleep_range(1000, 1500); + sdw_cdns_check_self_clearing_bits(cdns, "intel_resume_runtime BUS_RESET"); + } else if (!clock_stop_quirks) { clock_stop0 = sdw_cdns_is_clock_stop(&sdw->cdns); @@ -1963,6 +1973,9 @@ static int __maybe_unused intel_resume_runtime(struct device *dev) dev_err(dev, "unable to resume master during resume\n"); return ret; } + + usleep_range(1000, 1500); + sdw_cdns_check_self_clearing_bits(cdns, "intel_resume_runtime no_quirks"); } else { dev_err(dev, "%s clock_stop_quirks %x unsupported\n", __func__, clock_stop_quirks);