From 7186665088da07875c119793d55ad589d26207e4 Mon Sep 17 00:00:00 2001 From: hmacr Date: Thu, 5 Oct 2023 12:44:58 +0530 Subject: [PATCH 1/3] feat: add internal flag to job-run table --- apps/webapp/app/services/runs/createRun.server.ts | 1 + .../20231005064823_add_job_run_internal/migration.sql | 2 ++ packages/database/prisma/schema.prisma | 1 + 3 files changed, 4 insertions(+) create mode 100644 packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql diff --git a/apps/webapp/app/services/runs/createRun.server.ts b/apps/webapp/app/services/runs/createRun.server.ts index a3c7891934e..7c10897726f 100644 --- a/apps/webapp/app/services/runs/createRun.server.ts +++ b/apps/webapp/app/services/runs/createRun.server.ts @@ -70,6 +70,7 @@ export class CreateRunService { ? eventRecord.externalAccountId : undefined, isTest: eventRecord.isTest, + internal: job.internal, }, }); diff --git a/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql b/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql new file mode 100644 index 00000000000..c795fe22056 --- /dev/null +++ b/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql @@ -0,0 +1,2 @@ +-- AlterTable +ALTER TABLE "JobRun" ADD COLUMN "internal" BOOLEAN NOT NULL DEFAULT false; diff --git a/packages/database/prisma/schema.prisma b/packages/database/prisma/schema.prisma index 0bcdc154773..a1f96966e10 100644 --- a/packages/database/prisma/schema.prisma +++ b/packages/database/prisma/schema.prisma @@ -666,6 +666,7 @@ model EventRecord { model JobRun { id String @id @default(cuid()) number Int + internal Boolean @default(false) job Job @relation(fields: [jobId], references: [id], onDelete: Cascade, onUpdate: Cascade) jobId String From 422eed3dade0d9a4b71f23b1bcef1e590543fd33 Mon Sep 17 00:00:00 2001 From: hmacr Date: Fri, 6 Oct 2023 19:35:19 +0530 Subject: [PATCH 2/3] add backfill SQL --- .../20231005064823_add_job_run_internal/migration.sql | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql b/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql index c795fe22056..417057f7a25 100644 --- a/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql +++ b/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql @@ -1,2 +1,10 @@ -- AlterTable ALTER TABLE "JobRun" ADD COLUMN "internal" BOOLEAN NOT NULL DEFAULT false; + +/* + Backfill JobRun internal flag +*/ +UPDATE "JobRun" +SET "internal" = "Job"."internal" +FROM "Job" +WHERE "JobRun"."jobId" = "Job"."id"; \ No newline at end of file From e1ffecdf90f4747a8dc713c25981338e68671a7f Mon Sep 17 00:00:00 2001 From: Eric Allam Date: Fri, 6 Oct 2023 15:44:58 +0100 Subject: [PATCH 3/3] Update internal backfill to only update internal jobs --- .../20231005064823_add_job_run_internal/migration.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql b/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql index 417057f7a25..f226330db32 100644 --- a/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql +++ b/packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql @@ -7,4 +7,4 @@ ALTER TABLE "JobRun" ADD COLUMN "internal" BOOLEAN NOT NULL DEFAULT false; UPDATE "JobRun" SET "internal" = "Job"."internal" FROM "Job" -WHERE "JobRun"."jobId" = "Job"."id"; \ No newline at end of file +WHERE "JobRun"."jobId" = "Job"."id" AND "JobRun"."internal" = TRUE;