fix(player): account for rounding filling slider chapter end gap

mihar-22 · mihar-22 · commit 8faf9fd9a446 · 2023-10-03T02:37:28.000+11:00
diff --git a/packages/vidstack/src/components/ui/sliders/time-slider/slider-chapters.ts b/packages/vidstack/src/components/ui/sliders/time-slider/slider-chapters.ts
@@ -264,7 +264,7 @@ export class SliderChapters extends Component<SliderChaptersProps> {
       if (seenDuration) return;
 
       const { duration } = this._media.$state;
-      if (cues[cues.length - 1].endTime !== duration()) {
+      if (Math.abs(cues[cues.length - 1].endTime - duration()) > 1) {
         chapters.push(new window.VTTCue(cues[cues.length - 1].endTime, duration(), ''));
       }
 

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,7 @@ export class SliderChapters extends Component<SliderChaptersProps> {`
`264`	`264`	`if (seenDuration) return;`
`265`	`265`
`266`	`266`	`const { duration } = this._media.$state;`
`267`		`- if (cues[cues.length - 1].endTime !== duration()) {`
	`267`	`+ if (Math.abs(cues[cues.length - 1].endTime - duration()) > 1) {`
`268`	`268`	`chapters.push(new window.VTTCue(cues[cues.length - 1].endTime, duration(), ''));`
`269`	`269`	`}`
`270`	`270`