Skip to content

do not send image size on paste inpaint#16180

Merged
AUTOMATIC1111 merged 1 commit into
AUTOMATIC1111:devfrom
light-and-ray:do_not_send_image_size_on_paste_inpaint
Jul 20, 2024
Merged

do not send image size on paste inpaint#16180
AUTOMATIC1111 merged 1 commit into
AUTOMATIC1111:devfrom
light-and-ray:do_not_send_image_size_on_paste_inpaint

Conversation

@light-and-ray

@light-and-ray light-and-ray commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Description

This PR fixes a very annoying behavior: inpating in image something in "only masked" mode. Press "🎨️" to "commit" the changes. And this button overrides size option. This is wrong

I've just excluded "inpaint" tab from pasting w and h. But there are others solutions:

  1. Check "Inpaint area" == "Only masked" in source and ignore only for this case
  2. Prioritize "Size" in metadata over image's size. I.e. if it has "Size" in metadata, paste it
  3. Remove special handling of image's size at all, and handle it like other metadata. I don't know why you've added this behavior at all, because width and height are the same options like others

I would prefer the last

P.s. shared.opts.send_size has nothing with this case I think, because the behavior for "only masked" inpaint is wrong in any ways

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 986c31d into AUTOMATIC1111:dev Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants