Skip to content

Add runtime counter snapshots#46

Closed
MesTTo wants to merge 1 commit into
Adam-Vandervorst:masterfrom
MesTTo:pr/pathmap-counters
Closed

Add runtime counter snapshots#46
MesTTo wants to merge 1 commit into
Adam-Vandervorst:masterfrom
MesTTo:pr/pathmap-counters

Conversation

@MesTTo

@MesTTo MesTTo commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Adds the counter API only.

The branch introduces runtime counter snapshot, reset, read, and record helpers behind the existing counters feature. It does not wire counters into unrelated call sites.

Validation:

  • cargo check --features counters
  • cargo test --features counters counters::tests
  • jscpd on src/counters.rs

@MesTTo
MesTTo marked this pull request as ready for review June 23, 2026 10:23
@Adam-Vandervorst

Copy link
Copy Markdown
Owner

I don't see the value of this in its current form -- is this still WIP? Where would it be used?

@MesTTo

MesTTo commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

yeah you're right... i checked and nothing in pathmap actually touches these. the record sites and the readers both have zero callers, so on its own it's just dead plumbing. no point landing it like this. closing it and i'll bring the counters back together with the code that reads them. thanks for flagging.

@MesTTo MesTTo closed this Jun 24, 2026
@MesTTo
MesTTo deleted the pr/pathmap-counters branch July 4, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants