Add runtime counter snapshots#46
Closed
MesTTo wants to merge 1 commit into
Closed
Conversation
MesTTo
marked this pull request as ready for review
June 23, 2026 10:23
Owner
|
I don't see the value of this in its current form -- is this still WIP? Where would it be used? |
Contributor
Author
|
yeah you're right... i checked and nothing in pathmap actually touches these. the record sites and the readers both have zero callers, so on its own it's just dead plumbing. no point landing it like this. closing it and i'll bring the counters back together with the code that reads them. thanks for flagging. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the counter API only.
The branch introduces runtime counter snapshot, reset, read, and record helpers behind the existing counters feature. It does not wire counters into unrelated call sites.
Validation:
cargo check --features counterscargo test --features counters counters::testsjscpdonsrc/counters.rs