fix(agent): make feature guardian silent on success

[khaliqgant]

Summary

• keep the hourly Factory feature-catalog traversal running while recording healthy manifest/model/state traversal as structured log-only evidence
• remove scheduled Slack success writes, receipt polling, provider idempotency, and question registration
• retain the existing scoped Slack integration only for already-created guardian response/incident events
• migrate exact progress state from v3 Slack receipts to v4 log-only checkpoints while continuing to read deployed v3 state
• fail the deployment run on genuine manifest/catalog, exact-state load/CAS/save, and reconciliation failures so deployment monitoring can alert
• retain deterministic evidence fallback for an optional model failure so a transient generation issue does not create a false canary incident
• describe the scope accurately: catalog traversal does not claim per-feature functional E2E verification

RED-first evidence

The first commit adds the silent-success contract before the implementation commit. Before implementation, the healthy tick failed because it wrote one Slack message; the final test requires zero writes even with no channel configured. Genuine manifest/state failures separately require handler rejection.

Verification

• full guardian Vitest file, including conversation adapters: 40/40
• targeted strict TypeScript: pass
• Prettier for TypeScript and git diff --check: pass
• persona JSON validation: pass
• agentworkforce deploy ... --bundle-out: pass (one schedule, two integrations; Slack remains response-only)
• parity hardening: bounded legacy Slack epoch conversion with regression coverage

No merge or deployment was performed.

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[coderabbitai]

Warning

Review limit reached

@khaliqgant, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 91435f33-a222-4da6-8529-3108c2983a66

📥 Commits

Reviewing files that changed from the base of the PR and between 1b9b748 and 2ece61b.

📒 Files selected for processing (3)

• .agentworkforce/agents/factory-feature-guardian/agent.test.ts
• .agentworkforce/agents/factory-feature-guardian/agent.ts
• .agentworkforce/agents/factory-feature-guardian/persona.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/guardian-silent-success

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[khaliqgant]

RED-first attestation:

• Before the implementation change, the new healthy-run assertion failed: expected zero human Slack writes, received one.
• At this exact head, the full guardian test file (including conversation adapters) passes 39/39.
• The failure contract is covered separately: manifest/catalog, exact progress checkpoint, unsafe reconciliation, and missing production credentials reject the handler; optional model evidence uses a warn-only deterministic fallback.
• Healthy traversal is also proven with persona inputs cleared, so Slack channel configuration cannot gate the scheduled canary. Scoped Slack remains available only for existing response/incident events.

[khaliqgant]

Parity hardening from the Relay review is included in 2ece61b: legacy v3 receipt timestamps now reject out-of-range Date epochs with the canonical state error instead of leaking RangeError. Added the same regression matrix case; guardian suite is now 40/40, strict TypeScript and bundle staging green.