Fix degraded integration recovery guidance - #204
Conversation
📝 WalkthroughWalkthroughChangesRelayfile preflight
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/mount/relayfile-integration-preflight.test.ts (1)
135-155: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the new state-normalization path.
This fixture only uses canonical lowercase values, so it would still pass if
.trim().toLowerCase()were removed. Add a mixed-case/whitespace case and assert the intended diagnostic formatting.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/mount/relayfile-integration-preflight.test.ts` around lines 135 - 155, Extend the test for ensureFactoryIntegrations with mixed-case and surrounding-whitespace state values, such as state and initialSyncState, to exercise the normalization path. Update the expected rejection assertion to verify the diagnostic displays the normalized lowercase values, while preserving the existing assertions that no connection or wait calls occur.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/mount/relayfile-integration-preflight.test.ts`:
- Around line 135-155: Extend the test for ensureFactoryIntegrations with
mixed-case and surrounding-whitespace state values, such as state and
initialSyncState, to exercise the normalization path. Update the expected
rejection assertion to verify the diagnostic displays the normalized lowercase
values, while preserving the existing assertions that no connection or wait
calls occur.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: dead6eaa-169f-4cd9-bb0a-cc38f9cbe03c
📒 Files selected for processing (2)
src/mount/relayfile-integration-preflight.test.tssrc/mount/relayfile-integration-preflight.ts
Fixes #203.
When Relayfile reports an integration as
degradedafter initial sync is alreadycomplete, Factory now directs the operator to have a workspace owner repair or reconnect the provider. It no longer tells them to wait for an initial sync that has finished.Verification:
npx vitest run src/mount/relayfile-integration-preflight.test.ts(10 passed)npm run buildgit diff --checkSummary by cubic
Improve degraded integration recovery guidance by detecting when an integration is degraded after initial sync has completed. Operators now see clear instructions to ask a workspace owner to repair or reconnect the provider instead of waiting.
state: degradedandinitialSyncState: complete, show a repair/reconnect message and avoid the misleading “wait for initial sync” guidance.Written for commit 5f1c2a4. Summary will update on new commits.