Resolve internal issue #530: Integrate gemm-like example#82
Merged
12 commits merged intoSep 27, 2022
Merged
Conversation
added 4 commits
September 22, 2022 17:16
Add check of the numerical correctness Move explicit constants to variables Add debug prints
Test all combinations of transposed/non-transposed A and B General improvements to the unit test. Add asserts to check success of each operation. Fix const-ness of input parameters in gemm_like_example.
| constexpr double A_value = 2; | ||
| constexpr double B_value = 3; | ||
| constexpr double C_value = 4; | ||
| rc = rc ? rc : alp::set( A, alp::Scalar< double >( A_value ) ); |
There was a problem hiding this comment.
Would this (and next line) make it harder for us to assess the correct functioning of transposition?
Author
There was a problem hiding this comment.
Implemented matrix initialization with random values.
djelovina
approved these changes
Sep 23, 2022
added 8 commits
September 27, 2022 10:51
hidanielesgit
approved these changes
Sep 27, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.