Skip to content

TOF dev: move to next parameter container for pass handling#1989

Merged
njacazio merged 6 commits into
AliceO2Group:masterfrom
njacazio:nj-tofparams_per_pass
Feb 22, 2023
Merged

TOF dev: move to next parameter container for pass handling#1989
njacazio merged 6 commits into
AliceO2Group:masterfrom
njacazio:nj-tofparams_per_pass

Conversation

@njacazio

@njacazio njacazio commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator

@alibuild

alibuild commented Feb 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 8b72902 at 2023-02-14 23:01:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1989-slc7_x86-64/0/Common/TableProducer/PID/pidTOF.cxx:131:33: error: no matching function for call to 'o2::tof::ParameterCollection::print()'
/sw/slc7_x86-64/O2/nightly-20230214-local2/include/DataFormatsTOF/ParameterContainers.h:102:18: error: 'SetParameters' was not declared in this scope; did you mean 'setParameters'?
/sw/SOURCES/O2Physics/1989-slc7_x86-64/0/Common/TableProducer/PID/pidTOFFull.cxx:134:33: error: no matching function for call to 'o2::tof::ParameterCollection::print()'
/sw/slc7_x86-64/O2/nightly-20230214-local2/include/DataFormatsTOF/ParameterContainers.h:102:18: error: 'SetParameters' was not declared in this scope; did you mean 'setParameters'?
ninja: build stopped: subcommand failed.

Full log here.

@njacazio
njacazio force-pushed the nj-tofparams_per_pass branch from 8b72902 to 3bf1414 Compare February 16, 2023 05:44
@alibuild

alibuild commented Feb 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 3bf1414 at 2023-02-16 21:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1989-slc7_x86-64/0/ALICE3/TableProducer/alice3-pidTOF.cxx:126:80: error: reference to 'tof' is ambiguous
/sw/SOURCES/O2Physics/1989-slc7_x86-64/0/ALICE3/TableProducer/alice3-pidTOF.cxx:126:108: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/1989-slc7_x86-64/0/ALICE3/TableProducer/alice3-pidTOF.cxx:126:115: error: '::ComputeExpectedTime' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

@njacazio
njacazio enabled auto-merge (squash) February 17, 2023 12:11
@alibuild

alibuild commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 3a619d0 at 2023-02-17 17:14:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1989-slc7_x86-64/0/ALICE3/TableProducer/alice3-pidTOF.cxx:126:80: error: reference to 'tof' is ambiguous
/sw/SOURCES/O2Physics/1989-slc7_x86-64/0/ALICE3/TableProducer/alice3-pidTOF.cxx:126:108: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/1989-slc7_x86-64/0/ALICE3/TableProducer/alice3-pidTOF.cxx:126:115: error: '::ComputeExpectedTime' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

ddobrigk
ddobrigk approved these changes Feb 22, 2023
View reviewed changes

@ddobrigk ddobrigk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Nicolò!

@njacazio
njacazio disabled auto-merge February 22, 2023 10:10
@njacazio
njacazio enabled auto-merge (squash) February 22, 2023 10:10
alibuild
alibuild approved these changes Feb 22, 2023
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio
njacazio merged commit cb2409b into AliceO2Group:master Feb 22, 2023
@njacazio
njacazio deleted the nj-tofparams_per_pass branch February 22, 2023 10:11
lvermunt pushed a commit to lvermunt/O2Physics that referenced this pull request Mar 1, 2023
@njacazio @lvermunt
TOF dev: move to next parameter container for pass handling (AliceO2G…
a2eea22 
…roup#1989)

* TOF dev: move to next parameter container for pass handling

* Remove DetectorBase dependency
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Apr 3, 2023
@njacazio @hahassan7
TOF dev: move to next parameter container for pass handling (AliceO2G…
7f68f50 
…roup#1989)

* TOF dev: move to next parameter container for pass handling

* Remove DetectorBase dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@ddobrigk ddobrigk ddobrigk approved these changes
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ginnocen ginnocen Awaiting requested review from ginnocen
@vkucera vkucera Awaiting requested review from vkucera

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njacazio @alibuild @ddobrigk