Make O2DatabasePDG service class unambiguous - #3104
Merged
Merged
Conversation
This is a preparation for including the o2::O2DatabasePDG::Mass function in the o2::framework::O2DatabasePDG service.
vkucera
marked this pull request as ready for review
July 19, 2023 09:35
vkucera
requested review from
a team,
BongHwi,
ChiaraDeMartin95,
aalkin,
alibuild,
aortizve,
chiarapinto,
ddobrigk,
ginnocen,
hscheid,
iarsene,
iravasen,
jgrosseo,
ktf,
lbariogl,
lramona,
maoyx,
mbombara,
mfasDa,
njacazio,
nzardosh,
saganatt,
skundu692,
victor-gonzalez and
zchochul
as code owners
July 19, 2023 09:35
Collaborator
Author
|
@ktf @ddobrigk @benedikt-voelkel Please have a look. |
aalkin
approved these changes
Jul 19, 2023
nzardosh
approved these changes
Jul 20, 2023
vkucera
enabled auto-merge (squash)
July 21, 2023 11:19
Collaborator
Author
|
@jgrosseo, @victor-gonzalez, can you please approve for the CF? |
jgrosseo
approved these changes
Jul 24, 2023
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 6, 2023
This is a preparation for including the o2::O2DatabasePDG::Mass function in the o2::framework::O2DatabasePDG service.
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 7, 2023
This is a preparation for including the o2::O2DatabasePDG::Mass function in the o2::framework::O2DatabasePDG service.
zconesa
pushed a commit
to zconesa/O2Physics
that referenced
this pull request
Oct 27, 2023
This is a preparation for including the o2::O2DatabasePDG::Mass function in the o2::framework::O2DatabasePDG service.
chengtt0406
pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
This is a preparation for including the o2::O2DatabasePDG::Mass function in the o2::framework::O2DatabasePDG service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation for including the
o2::O2DatabasePDG::Massfunction in theo2::framework::O2DatabasePDGservice.It has to be merged first, to avoid the
template argument 1 is invaliderror.