feat: manifest onboarding - #2
Closed
gaurpulkit wants to merge 2 commits into
Closed
Conversation
suryaiyer95
reviewed
Jan 26, 2024
| @click.option("--tenant", prompt="Tenant", help="Your tenant ID.") | ||
| @click.option("--dbt_core_integration_id", prompt="DBT Core Integration ID", help="DBT Core Integration ID") | ||
| @click.option("--manifest-path", prompt="Manifest Path", help="Path to the manifest file.") | ||
| def onboard(token, tenant, dbt_core_integration_id, manifest_path, env): |
Collaborator
There was a problem hiding this comment.
This should go to the dbt cli.py
suryaiyer95
reviewed
Jan 26, 2024
| token = os.environ.get("DBT_API_TOKEN") | ||
|
|
||
| if not token or not tenant: | ||
| print("Error: API Token is required.") |
suryaiyer95
reviewed
Jan 26, 2024
| def onboard(token, tenant, dbt_core_integration_id, manifest_path, env): | ||
| """Onboard a manifest file to DBT.""" | ||
| if not token and env: | ||
| token = os.environ.get("DBT_API_TOKEN") |
Collaborator
There was a problem hiding this comment.
ALTIMATE_API_KEY
ALTIMAT_INSTANCE_NAME
suryaiyer95
reviewed
Jan 26, 2024
suryaiyer95
reviewed
Jan 26, 2024
| with open(manifest_path, "rb") as file: | ||
| file_content = file.read() | ||
|
|
||
| upload_response = api_client.post(signed_url, data=file_content) |
Collaborator
There was a problem hiding this comment.
Maybe this can be a util
load_cpntent_to_signed_url()
suryaiyer95
reviewed
Jan 29, 2024
| headers = self._get_headers() | ||
|
|
||
| self.logger.debug(f"Sending GET request for tenant {self.tenant} at url: {url}") | ||
| print(f"Sending GET request for tenant {self.tenant} at url: {url}") |
Contributor
Author
There was a problem hiding this comment.
Prints are the only thing that are appearing in my terminal. logger.debug isn't showing up at all
suryaiyer95
reviewed
Jan 29, 2024
| click.echo("Error: API Token is required.") | ||
| return | ||
|
|
||
| # if not validate_credentials(token, tenant): |
Collaborator
|
stale and not needed. |
Sourabhchrs93
added a commit
that referenced
this pull request
Jul 22, 2026
…-v5 parsers (#108) Mirror of the v6 `Status` shim (AI-7435, PR #106) for the pre-v6 schemas, closing the residual of AI-7675 finding #2: any run status outside `success`/`error`/`skipped` (e.g. dbt 2.0 `reused`, or any future status) raised a `ValidationError` in run_results v1-v5 and the ingestion worker silently dropped the entire `run_results.json`. - Make `Status` a `str, Enum`, add `reused`, and add the `_missing_` forward-compat fallback so unknown statuses surface as real members instead of failing validation (identical to the v6 fix). - Reorder `RunResultOutput.status` to `Union[Status1, Status2, Status]` so test/freshness statuses (`pass`/`fail`/`warn`/`runtime error`) keep resolving via the strict enums and the permissive run `Status` is tried last (same reordering as v6). - Add parameterized regression tests over v1-v5 mirroring `test_run_results_v6.py`, including full-file `parse_run_results`. Freshness-specific enums (`Status3`/`Status4` in v3/v4) are untouched, matching the v6 fix scope. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.