Conversation
ncoop57
marked this pull request as ready for review
July 22, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_hlmethod gated highlighting onlang in languages(), which excluded valid aliases likepythat the highlighter itself accepts. Removed the pre-check and catchValueErrorinstead, so aliases highlight and unknown languages are left untouched as before.Changes
python/mdhtml/export.py: droplanguagesimport; attempt the highlight and catchValueErrorfor unknown langs rather than pre-filtering againstlanguages()tests/test_export.py: addtest_hl_lang_aliascovering both alias resolution (```py) and graceful skip for unknown languages (```nosuchlang)Notes
Behavior change is strictly additive — aliases fastpylight accepts now highlight, unknown languages are skipped as before.