chore(deps): refresh @archastro/channel-harness lock to 0.4.0 (SSE harness) - #29
Merged
Merged
Conversation
…rness) package.json already tracks "latest", but the lockfile pinned the stale 0.2.4, which predates the harness's SSE support (registerStreamScenario + text/event-stream serving). `npm ci` would install 0.2.4, so the generated SSE stream contract tests couldn't run. Refresh the lock to 0.4.0 (package.json unchanged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Refreshes the lockfile resolution of
@archastro/channel-harnessfrom the stale 0.2.4 to 0.4.0.package.jsonalready tracks"latest", so no manifest change — just the lock.Why
0.2.4predates the harness's SSE support (register_stream_scenario+text/event-streamserving, in 0.3.0/0.4.0).npm ciinstalls from the lock, so it would pull the stale harness and the generated SSE stream contract tests (tests/contract/streams/test_*.py, now emitted bysdk-generator@0.7.0) couldn't run.Scope / risk
Low — JS test-tooling lockfile only (the channel-harness subprocess that backs contract tests); no Python runtime change. SSE stream tests are opt-in (
ARCHASTRO_RUN_CHANNEL_CONTRACT_TESTS=1), so default CI is unaffected.Follow-up
To actually run the Python SSE stream tests, the hand-written
phx_channel/harness.pyHarnessServiceClientstill needs aregister_stream_scenariomethod (the TS harness client already hasregisterStreamScenario). Tracked separately — this PR just unblocks the harness version.