Avoid duplicate preemptive Digest hashing#2276
Open
pavel-ptashyts wants to merge 1 commit into
Open
Conversation
Preemptive auth-int built temporary Realm objects and recalculated HA1 before rebuilding the realm again. The final build also overwrote the response that included the request body. Pass the entity-body hash to the request-specific realm builder and build it once for both origin and proxy authentication. Remove the duplicate digest calculation path and verify the emitted response independently. Codex on behalf of Pavel Ptashyts Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Realm.BuilderThis follows the entity-body-hash flow already used by the 401 and 407 interceptors. It does not modify
Realm.java, so it remains compatible with #2269.Verification
./mvnw -pl client -Dtest=org.asynchttpclient.util.AuthenticatorUtilsTest,org.asynchttpclient.RealmTest,org.asynchttpclient.DigestAuthTest,org.asynchttpclient.DigestAuthRfc7616Test test(53 tests passed)./mvnw -B -ntp -pl client -DskipTests -Dmaven.javadoc.skip=true -Dgpg.skip=true verify(Revapi passed)The full JDK 11
./mvnw clean verifygate was not run because this environment provides JDK 21 only.Codex on behalf of Pavel Ptashyts