Migrate to AndroidX#11
Merged
Merged
Conversation
rpdome
requested review from
heidijinxujia,
iambmelt,
kreedula,
shahzaibj and
shoatman
August 6, 2019 01:46
kreedula
approved these changes
Aug 6, 2019
rpdome
force-pushed
the
UpdateGradleProperties
branch
from
August 6, 2019 01:48
a8c59e2 to
ad1f854
Compare
shahzaibj
added a commit
that referenced
this pull request
Jul 16, 2026
…k rename, harden stub-detection Review-fix round on the rolling-7-day-window PR: - Scrub all personal/ticket self-attribution (Fadi / AB#3683194 / feedback-date) from the skill; rewrite rationale impersonally. Legitimate report-content AB# placeholders (Likely-PRs field, code-attribution template, sample report) kept. - Rename the two-bucket `wk` column to `week` across every KQL template and every JS/PS consumer (agg.js, summarize-attribution.js, bucket-trends.js, validate-report.ps1). Dropped the now-dead `wk` schema fallbacks. Verified end-to-end: zero remaining `wk`, all three JS readers consume `week`. - Fix the SKILL.md "Resolved reporting window" example so every line derives from one today (2026-07-15): Last-7d 07-08->07-15, 60d 05-16->07-15, cutoff 07-12. - template-readme.md: Generated date is UTC by contract -> recommend a UTC formatter, stop warning against toISOString(). - report-template.html appendix: genericize hardcoded methodology dates. - validate-report.ps1: align checklist numbering (add #10 fabricated-sparkline; rolling-window header integrity is #11 in docstring, code header, and SKILL.md). - Harden bootstrap stub/collision detection: inject an OCE-UNPOPULATED-STUB sentinel; a same-day report is silently re-bootstrapped only when it still carries that sentinel AND the template's first KPI, else refuse+exit unless -Force. validate-report.ps1 fails if the sentinel is still present, so a published report can never be misclassified as a stub. - Document the override limitation in SKILL.md: only -EndDate is supported; no custom start-date or arbitrary span. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 81d709d0-6563-48f0-8f7c-45ba179ee38e
shahzaibj
added a commit
that referenced
this pull request
Jul 24, 2026
…ay, Fixes AB#3683194 (#447) Fixes [AB#3683194](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3683194) ## Feedback From Fadi Durah's ★4 skill-effectiveness survey (Jun 2026, `oncall-weekly-telemetry-report`): > *"The telemetry skill was certainly helpful, the biggest feedback is that it seemed to capture the wrong timeframe (didn't capture the most recent 6 days). I'm sure I could've spent some time with it to get it to target the right date, but this is probably something that should happen by default in order to save more time for the developer, and something moumita has been pushing for."* ## Root cause (repro'd on today's clock, Thu 2026-07-09) `bootstrap-report.ps1` was computing "reporting Sunday" as the most recent Sunday strictly before today — which is the Sunday of the **currently in-progress** week. Run on a Thursday it picked `Sun 2026-07-05 → Sat 2026-07-11` where Saturday is 2 days in the future, so the WoW section queried a 4-day partial window and dropped the last complete week. Exactly Fadi's *"missed the last 6 days"* complaint. `SKILL.md` then compounded it by asking the model to confirm the Sunday with the user — the manual coax that the developer shouldn't have to do. | Today (UTC) | Old default (broken) | New default | |-----------------|------------------------------------------|------------------------------------------| | Thu 2026-07-09 | Sun **07-05** → Sat **07-11** (future!) | Thu **07-02** → Thu **07-09** ✅ | | Mon 2026-07-13 | Sun **07-12** → Sat **07-18** (future!) | Mon **07-06** → Mon **07-13** ✅ | ## Fix Per the user's direction, deep rewrite: rolling `[today−7d, today)` for the primary WoW view, keeping Sun-Sat weekly bucketing only for the 60-day trend (where stable weekly denominators still matter). - **`bootstrap-report.ps1`** — new `-EndDate` param (default: today UTC). Computes `curStart = curEnd−7d`, `prevStart = curEnd−14d`, and `trendEnd = startofweek(curEnd)`. **Stamps the resolved window into the `<title>`, `<div class="meta">` block, and Generated banner** so header dates can never drift from what was queried (this is the ADO acceptance criterion). Refuses future end-dates. Collision fingerprint stopped keying off title/meta (which bootstrap now rewrites unconditionally) — uses `firstKpi` + size ratio only. - **15 KQL templates** — 12 primary/WoW queries switched to half-open `[prevStart, curEnd)` with `wk = iff(EventInfo_Time >= curStart, curStart, prevStart)`; downstream JS helpers unchanged because `wk` still sorts lexicographically. The 3 60-day-trend queries keep `startofweek()` bucketing; only `<END>` renamed to `<TREND_END>` with clarified `startofweek(today)`-exclusive semantics. Placeholder audit is now consistent across all 15 files. - **`SKILL.md`** — rewrote *Inputs to confirm §1*: **do NOT ask the user for a date by default; just run bootstrap.** Override via `-EndDate` only when the user explicitly requests a non-default window. Filename convention `<sunday>` → `<end-date>` throughout. All KQL placeholder examples switched to the rolling-window form. - **`validate-report.ps1`** — new check #11 asserts the meta-line "Last 7 days" dates are self-consistent with the filename's end-date. Catches any hand-edit that broke the auto-stamp, or a stale template stub being published fresh. - **Docs** — `template-readme.md` § *Date fields* rewritten (bootstrap owns every date field; author never edits them). `kusto-cheatsheet.md` gains § 3 *Rolling 7-day WoW window* with the canonical `let curStart/curEnd/prevStart` template; the pre-existing `startofweek()`-alignment section is now scoped explicitly to the 60-day trend. ## Breaking changes (intentional) - `bootstrap-report.ps1`: `-ReportingSunday` parameter **removed**; use `-EndDate`. The old parameter name encoded the exact semantic mismatch that caused the bug — keeping it would have preserved the footgun. - Output filename: `oncall-wow-report-<end-date>.html` (was `<sunday>.html`). Old on-disk reports are unaffected. ## Verification - Run on 2026-07-09 → correctly resolves to `[2026-07-02, 2026-07-09)`. - `-EndDate 2026-07-02` → `[2026-06-25, 2026-07-02)`. - `-EndDate 2027-01-01` → refused (future-date guard). - Same-day re-bootstrap of unfilled stub → silently overwrites. - Same-day re-bootstrap after author populated KPI → HARD HALT exit 2 unless `-Force`. - Validator check #11 passes on fresh stub, FAILs on a hand-mutated meta line. - Placeholder audit across all 15 rewritten .kql files — no stale `<START>`/`<END>`/`<CURR_*>`/`<PREV_WEEK>` references remain. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 81d709d0-6563-48f0-8f7c-45ba179ee38e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.