Enable broker support on Linux platform - #5086
Merged
Merged
Conversation
gladjohn
reviewed
Jan 16, 2025
gladjohn
reviewed
Jan 16, 2025
gladjohn
reviewed
Jan 16, 2025
gladjohn
reviewed
Jan 16, 2025
gladjohn
reviewed
Jan 16, 2025
gladjohn
reviewed
Jan 16, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (5)
- Directory.Packages.props: Language not supported
- NuGet.Config: Language not supported
- src/client/Microsoft.Identity.Client.Broker/Microsoft.Identity.Client.Broker.csproj: Language not supported
- tests/devapps/WAM/NetWSLWam/Properties/launchSettings.json: Language not supported
- tests/devapps/WAM/NetWSLWam/test.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs:59
- [nitpick] The method name 'IsRunningOnWsl' could be more descriptive. Consider renaming it to 'IsRunningOnWindowsSubsystemForLinux'.
public static bool IsRunningOnWsl()
src/client/Microsoft.Identity.Client.Broker/RuntimeBroker.cs:129
- Replace the debug log statement with a proper logging mechanism: _logger.Info("Runtime Broker AcquireTokenInteractiveAsync");
Console.WriteLine("Runtime Broker AcquireTokenInteractiveAsync");
gladjohn
reviewed
Jan 16, 2025
bgavrilMS
reviewed
Jan 18, 2025
bgavrilMS
reviewed
Jan 18, 2025
This was referenced May 20, 2026
This was referenced Jun 5, 2026
Closed
Closed
This was referenced Jun 19, 2026
Closed
Closed
This was referenced Jun 29, 2026
Closed
This was referenced Jul 9, 2026
Closed
This was referenced Jul 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
Testing
Performance impact
Documentation