Skip to content

Enable broker support on Linux platform - #5086

Merged
xinyuxu1026 merged 151 commits into
mainfrom
xinyu/wsl-support
Feb 24, 2025
Merged

Enable broker support on Linux platform#5086
xinyuxu1026 merged 151 commits into
mainfrom
xinyu/wsl-support

Conversation

@xinyuxu1026

@xinyuxu1026 xinyuxu1026 commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

Fixes #

Changes proposed in this request

  • Add broker support on Linux and WSL platforms
    • Linux platform doesn't require a new one to be registered, it should be able to use the same redirect_uri as Windows platform.
    • For parent window, on Linux we import libX11 to get the window handle, and this applies to both Linux and WSL since they are both Linux environments
    • Linux broker doesn't support POP
  • Update msalruntime to version 0.18.0

Testing

  • Microsoft.Identity.Test.Integration.NetCore tests are enabled in the CI for Linux platform
  • Manual testing: test Msalruntime flow in WSL(Windows Subsystem for Linux)

Performance impact

Documentation

  • All relevant documentation is updated.

@xinyuxu1026
xinyuxu1026 requested a review from a team as a code owner January 16, 2025 00:05
Comment thread NuGet.Config Outdated
Comment thread Directory.Packages.props
Comment thread src/client/Microsoft.Identity.Client.Broker/RuntimeBroker.cs Outdated
Comment thread tests/devapps/WAM/NetWSLWam/test.csproj
Comment thread src/client/Microsoft.Identity.Client.Broker/RuntimeBroker.cs
@gladjohn
gladjohn requested a review from Copilot January 16, 2025 05:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • Directory.Packages.props: Language not supported
  • NuGet.Config: Language not supported
  • src/client/Microsoft.Identity.Client.Broker/Microsoft.Identity.Client.Broker.csproj: Language not supported
  • tests/devapps/WAM/NetWSLWam/Properties/launchSettings.json: Language not supported
  • tests/devapps/WAM/NetWSLWam/test.csproj: Language not supported
Comments suppressed due to low confidence (2)

src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs:59

  • [nitpick] The method name 'IsRunningOnWsl' could be more descriptive. Consider renaming it to 'IsRunningOnWindowsSubsystemForLinux'.
public static bool IsRunningOnWsl()

src/client/Microsoft.Identity.Client.Broker/RuntimeBroker.cs:129

  • Replace the debug log statement with a proper logging mechanism: _logger.Info("Runtime Broker AcquireTokenInteractiveAsync");
Console.WriteLine("Runtime Broker AcquireTokenInteractiveAsync");

Comment thread src/client/Microsoft.Identity.Client.Broker/BrokerExtension.cs Outdated
Comment thread src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs Outdated
Comment thread src/client/Microsoft.Identity.Client/ApiConfig/BrokerOptions.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants