Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
s-aher
marked this pull request as ready for review
June 22, 2026 07:08
stampercasey
left a comment
stampercasey
left a comment
There was a problem hiding this comment.
Review from Claude Code — see inline comments for individual findings. One blocker (regen job); the verb implementation is otherwise sound.
Regen job has not run — models/refer-complete-callback.ts is absent and bandwidth.yml was not updated. The PR description lists this as a follow-up pending api-specs#2142, which has now merged (June 12). The regen needs to run and ReferCompleteCallback + the four scenario tests need to land before this is ready to merge.
stampercasey
previously approved these changes
Jun 23, 2026
… in Refer ReferCompleteCallback will land later via a separate api-specs-driven PR once VAPI-3440 merges. Refer now takes the existing Transfer-flavored SipUri instead of a duplicate ReferSipUri type, matching the reviewed csharp-sdk reference implementation (no runtime validation, no builder bloat).
models/refer-call-status.ts had no consumer once ReferSipUri/ReferCompleteCallback were removed from this PR's scope. bandwidth.yml still carried the full referCompleteCallback/referCallStatus/referSipResponseCode/notifySipResponseCode schemas and a referComplete addition to the shared eventType enum description. Also cleaned up the corresponding .openapi-generator/FILES entries.
…return type tsc (with declaration:true) failed on common.ts:110 - 'The inferred type of createRequestFunction references an inaccessible unique symbol type' - because axios 1.19's request<T,R>() return type involves an internal branded type not portable to a .d.ts. This broke npm run build (invoked via yarn's prepare hook) on every OS/Node matrix job in CI, on main as well as this PR. Annotating the returned function's return type as Promise<R> sidesteps emitting the unexported internal type.
Comment on lines
-111
to
+113
| return <T = unknown, R = AxiosResponse<T>>(axios: AxiosInstance = globalAxios, basePath: string = BASE_PATH) => { | ||
| return function <T = unknown, R = AxiosResponse<T>>(axios: AxiosInstance = globalAxios, basePath: string = BASE_PATH): Promise<R> { | ||
| const axiosRequestArgs = {...axiosArgs.options, url: (axios.defaults.baseURL ? '' : configuration?.basePath ?? basePath) + axiosArgs.url}; | ||
| return axios.request<T, R>(axiosRequestArgs); | ||
| return axios.request<T, R>(axiosRequestArgs) as Promise<R>; |
There was a problem hiding this comment.
Fix for CI error unrelated to PR change. Actions aren't required so can remove this if wanted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
<Refer>BXML verb.models/bxml/verbs/Refer.ts: newReferverb (referCompleteUrl,referCompleteMethod,tagattributes, one requiredSipUrichild).SipUritype for the child element instead of a separateReferSipUri- no runtime validation restricting whichSipUriattributes are legal per verb (matches csharp-sdk#201, which dropped this as over-engineering).ReferCompleteCallbackmodel is out of scope here - lands separately once VAPI-3440 merges. Deleted the orphaned generatedmodels/refer-call-status.ts/docs/ReferCallStatus.mdand the correspondingbandwidth.ymlschemas, which had no remaining consumer once that callback work was descoped.common.ts: fixed a pre-existing TS2527 build error (unrelated to Refer, also present onmain) that was failingnpm run buildon every CI matrix job - annotatedcreateRequestFunction's return type to avoid emitting an axios-internal type that isn't portable to a.d.ts.tests/unit/models/bxml/verbs/Refer.test.ts.Tests:
npm run buildandnpx jest- full suite passes (257/257 test files).VAPI-3439