test(node): raise vitest hook timeout to 15s - #495
Merged
pratyush618 merged 1 commit intoJul 22, 2026
Conversation
Dashboard beforeEach hooks seed a PBKDF2 session that can outrun the 10s default on slow CI runners.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Node SDK Vitest configuration increases the hook timeout to 15,000 milliseconds and adds a comment describing its purpose for slower CI dashboard hook seeding. ChangesVitest timeout configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pratyush618
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Windows Node smoke job on master is flaky:
test/dashboard/inspectRoutes.test.ts > 404s a replay of an unknown jobfails withHook timed out in 10000ms. (run)The failing hook is the dashboard suite's
beforeEach, which seeds an admin session viaseedAdminAndSession— a PBKDF2 hash at 600k iterations. On a contended CI runner that can exceed vitest's 10s default hook timeout.testTimeoutwas already raised to 15s, buthookTimeoutwas left at the default, so the setup hook had less headroom than the test it sets up.Fix
Set
hookTimeout: 15000invitest.config.tsto matchtestTimeout. One line, covers every dashboard test that seeds a session (not just the one that happened to trip this run).Unrelated to the webhook store change in #494 — this hook flake predates it and affects the whole dashboard suite.
Summary by CodeRabbit