Feature/14 my page layout - #15
Merged
Merged
Conversation
syeonnn
changed the title
arinming
requested changes
Jul 21, 2023
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent"> | ||
|
|
||
| <LinearLayout |
Member
There was a problem hiding this comment.
LinearLayout 네이밍 룰에 대해 다같이 고민해봐야 할 것 같아요!
Contributor
Author
There was a problem hiding this comment.
imageview=>iv 말씀하신것처럼 linearlayout => 'll_어쩌구' 로 통일하면 어떨까요..?
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent"> | ||
|
|
||
| <ImageView |
Member
There was a problem hiding this comment.
ImageView Id는 iv_mypage_ic_user
이런식으로, 'iv' 로 통일하는 거 어때요?!
| android:layout_width="0dp" | ||
| android:layout_height="40dp" | ||
| android:layout_weight="10"> | ||
| <TextView |
Member
There was a problem hiding this comment.
id 명은 btn으로, TextView인데 btn으로 오해할 수 있을 것 같아요!
Member
|
고생하셨습니다!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.