#P09 As a participant - I would like to submit my entry. - #87
Conversation
TravelTimN
left a comment
TravelTimN
left a comment
There was a problem hiding this comment.
Looking great!
A few minor adjustments outlined below! 🦗
|
@ClaireLally8 sorry, I did not want to pile on and be the 3rd person to review your pull request, but since we were talking about your PR a bit I would be amiss not to review it for you!! Also, only for a few minor things I think it looks really good! 🥇 |
|
Thanks y'all @stefdworschak @TravelTimN @Eventyret I guess I'll fix these at some stage today ;) (but please, be perfectionists, I need to get better at the refining stuff!) |
|
If you don't approve this *shakes fist * |
stefdworschak
left a comment
stefdworschak
left a comment
There was a problem hiding this comment.
@ClaireLally8 gonna approve this now since you are threatening me (yes, I am referring to the fist shaking lol). Please have a look at my final few comments and I will merge it when you revert back.
| deployed_url = models.URLField(default="", max_length=255) | ||
| submission_time = models.DateTimeField(auto_now_add=True) | ||
| speaker_name = models.CharField(default="", max_length=225) | ||
| share_permission = models.BooleanField(default=True) |
There was a problem hiding this comment.
Do we need this here? Or more specifically can the person submitting the project legally agree to the sharing permissions for all team members? I would say we put something in the T&Cs when signing up that they need to confirm that any work that is produced as part of participating on this platform can be shared. @TravelTimN what do you think about this?
|
@ClaireLally8 @TravelTimN I am going to merge this now and will create a follow up issue for ourselves to decide this. |
4 participants
Description
Creates the app for the submissions of completed hackathon project. Utilises the HackProject model and is filled out with a form by the users.
Pull request type
Testing
Manual testing by checking it functions.
Automated testing - * crickets *
Additional Information
Will need the templates edited as these are not finalised. Found within the submissions/templates/submissions folder :)
Does this introduce a breaking change