London | 26-ITP-May | Russom Gebremeskel | Sprint 1 | Coursework - #1339
Open
russom-g wants to merge 39 commits into
Open
London | 26-ITP-May | Russom Gebremeskel | Sprint 1 | Coursework#1339russom-g wants to merge 39 commits into
russom-g wants to merge 39 commits into
Conversation
…the last set of test.
…ested and passed.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
changed the title
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on these. Functionally they are correct, but they could be improved further
| } | ||
| } | ||
| if (elements.length === arr.length) { | ||
| return arr.slice(); |
There was a problem hiding this comment.
Why do you need this if branch? What does it do?
Author
There was a problem hiding this comment.
Hi @LonMcGregor Thanks for the review and feedback first of all.
I must have forgot to delete it when I finished working on this specific program. It is deleted now.
| return sum; | ||
| } | ||
|
|
||
| let numbers = ["c", "b", "hi", 1]; |
There was a problem hiding this comment.
Is there a better place to put this test case?
Author
There was a problem hiding this comment.
Yes. I forgot the remove this after I finished testing with it. I was rushing with my work and i forget to tidy up a few things. I know this isn't a good excuse. It is deleted now.
| test.todo("given an empty array, it returns an empty array"); | ||
| //test.todo("given an empty array, it returns an empty array"); | ||
| test("given an empty array, it returns an empty array", function() { | ||
| console.log(dedupe) |
There was a problem hiding this comment.
Why are you logging something here?
Author
There was a problem hiding this comment.
Again I must have left it there by mistake. I deleted it now.
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this sprint fix, implement, refactor codes worked on.