Skip to content

London | 25-ITP-May | Mandip Sanger | Sprint 3| Dead Code - #1587

Open
mandipsanger wants to merge 3 commits into
CodeYourFuture:mainfrom
mandipsanger:sprint-3/dead-code
Open

London | 25-ITP-May | Mandip Sanger | Sprint 3| Dead Code#1587
mandipsanger wants to merge 3 commits into
CodeYourFuture:mainfrom
mandipsanger:sprint-3/dead-code

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Dead code sprint 3 coursework

@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger added 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
Luro91
Luro91 reviewed Jul 30, 2026
View reviewed changes
Comment thread Sprint-3/3-dead-code/exercise-1.js Outdated
console.log(greetingStr);
}

testName = "Aman";

@Luro91 Luro91 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could you simplify the assignment of the testName variable?

@mandipsanger mandipsanger Jul 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by adding template literal

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Luro91 Luro91 Luro91 left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Structuring-And-Testing-Data The name of the module. 🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandipsanger @Luro91