Propagate trace context across Guidewire WSI SOAP worker threads - #12125
Draft
ValentinZakharov wants to merge 1 commit into
Draft
Propagate trace context across Guidewire WSI SOAP worker threads#12125ValentinZakharov wants to merge 1 commit into
ValentinZakharov wants to merge 1 commit into
Conversation
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: eefb670 | Docs | Datadog PR Page | Give us feedback! |
ValentinZakharov
force-pushed
the
vzakharov/guidewire
branch
6 times, most recently
from
August 3, 2026 12:46
1d2498c to
6db4a35
Compare
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
ValentinZakharov
force-pushed
the
vzakharov/guidewire
branch
from
August 3, 2026 13:28
6db4a35 to
939ccf2
Compare
ValentinZakharov
force-pushed
the
vzakharov/guidewire
branch
from
August 3, 2026 13:34
939ccf2 to
eefb670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds a
guidewireinstrumentation so outbound SOAP calls keep their trace context.Guidewire runs every SOAP call on its own raw thread (
AsyncResponseImpl$WebserviceInvocationThread, shown as"WSI-Invocation"). We grab the current context when that thread is created and restore it when it runs, so the SOAP http.request span stays attached to its parent instead of starting a new traceMotivation
The agent propagates context for thread pools, but not for a plain
new Thread().start()- which is exactly how Guidewire makes SOAP calls. So the SOAP spans lost their parent (parent_id=0).We can't instrument
java.lang.Threaddirectly (it's on the agent's ignore list and loads before the agent), so we instrument Guidewire's own thread subclass insteadAdditional Notes
run()), so it works on its own. If the default runnable instrumentation also wrapsrun(), that's safe - the context is only consumed once.AsyncResponseImpl$…that extends Thread). Normal thread-pool workers are not touched.DD_TRACE_GUIDEWIRE_ENABLED(on by default)Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]