Skip to content

Migrate OpenTelemetry smoke test to JUnit - #12127

Open
PerfectSlayer wants to merge 1 commit into
bbujon/smoke-tests-junit-frameworkfrom
bbujon/smoke-tests-opentelemetry
Open

Migrate OpenTelemetry smoke test to JUnit#12127
PerfectSlayer wants to merge 1 commit into
bbujon/smoke-tests-junit-frameworkfrom
bbujon/smoke-tests-opentelemetry

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

What Does This Do

This PR migrates the OpenTelemetry smoke tests to the new JUnit smoke test framework.

Motivation

The new tests checks the whole trace structures and span values, in addition to trace payload validity and invariants.

Additional Notes

Contributor Checklist

Jira ticket: APMLP-1247

@PerfectSlayer PerfectSlayer added the type: feature Enhancements and improvements label Aug 3, 2026
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 3, 2026 13:26
@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Aug 3, 2026
@PerfectSlayer
PerfectSlayer requested review from mtoffl01 and removed request for a team August 3, 2026 13:26
@PerfectSlayer PerfectSlayer added the inst: opentelemetry OpenTelemetry instrumentation label Aug 3, 2026

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The JUnit migration preserves the OpenTelemetry smoke application launch and validates its one annotated trace plus ten sequential manual traces with the new backend assertions. No diff-only behavioral regression was confirmed; no additional tests recommended because the existing application shape is deterministic and the attempted module execution was blocked by unavailable Gradle/JDK tooling.

Was this helpful? React 👍 or 👎

📊 Validated against 3 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 9eece4a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9eece4ad18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +30 to +31
app.traces()
.assertTraces(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the 30-second trace polling window

On slower CI workers or JVM variants where agent startup and trace delivery take more than 10 seconds, this migration can now fail even though the application still completes within its intended 30-second allowance: the deleted test's defaultPoll waited 30 seconds, while this call uses Traces.assertTraces's 10-second default and TIMEOUT_SECONDS is applied only afterward to the process wait. Pass the 30-second timeout to the trace assertion as well so the migration does not shorten the trace-delivery deadline.

Useful? React with 👍 / 👎.

@dd-octo-sts

dd-octo-sts Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 14.01 s [-0.7%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 12.87 s 13.03 s [-2.0%; -0.4%] (maybe better)
startup:petclinic:appsec:Agent 16.93 s 17.00 s [-1.4%; +0.5%] (no difference)
startup:petclinic:iast:Agent 17.07 s 17.04 s [-0.5%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 16.92 s 17.06 s [-2.1%; +0.5%] (no difference)
startup:petclinic:sca:Agent 16.73 s 16.53 s [+0.4%; +2.0%] (maybe worse)
startup:petclinic:tracing:Agent 16.19 s 16.19 s [-1.0%; +1.0%] (no difference)

Commit: f9175c82 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-junit-framework branch from 0f9f704 to 5080400 Compare August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer requested a review from mcculls August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from 9eece4a to e3bc1dc Compare August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from e3bc1dc to f9175c8 Compare August 4, 2026 11:32
@datadog-datadog-prod-us1-2

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant