Migrate OpenTelemetry smoke test to JUnit - #12127
Conversation
There was a problem hiding this comment.
More details
The JUnit migration preserves the OpenTelemetry smoke application launch and validates its one annotated trace plus ten sequential manual traces with the new backend assertions. No diff-only behavioral regression was confirmed; no additional tests recommended because the existing application shape is deterministic and the attempted module execution was blocked by unavailable Gradle/JDK tooling.
📊 Validated against 3 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 9eece4a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9eece4ad18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| app.traces() | ||
| .assertTraces( |
There was a problem hiding this comment.
Preserve the 30-second trace polling window
On slower CI workers or JVM variants where agent startup and trace delivery take more than 10 seconds, this migration can now fail even though the application still completes within its intended 30-second allowance: the deleted test's defaultPoll waited 30 seconds, while this call uses Traces.assertTraces's 10-second default and TIMEOUT_SECONDS is applied only afterward to the process wait. Pass the 30-second timeout to the trace assertion as well so the migration does not shorten the trace-delivery deadline.
Useful? React with 👍 / 👎.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
0f9f704 to
5080400
Compare
9eece4a to
e3bc1dc
Compare
e3bc1dc to
f9175c8
Compare
What Does This Do
This PR migrates the OpenTelemetry smoke tests to the new JUnit smoke test framework.
Motivation
The new tests checks the whole trace structures and span values, in addition to trace payload validity and invariants.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1247