-
Notifications
You must be signed in to change notification settings - Fork 12
Carve slow/e2e tests into separate testSlow tasks #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -169,17 +169,25 @@ jobs: | |
| with: | ||
| configuration: '["debug", "asan"]' | ||
|
|
||
| pre-release-slow-tests: | ||
| needs: validate-inputs | ||
| if: ${{ inputs.dry_run != true && inputs.skip_tests != true && inputs.release_type != 'retag' }} | ||
| uses: ./.github/workflows/test_workflow.yml | ||
| with: | ||
| configuration: '["debug"]' | ||
| slow_tests: true | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For every normal release validation, this call and Useful? React with 👍 / 👎. |
||
|
|
||
| create-release: | ||
| needs: [validate-inputs, pre-release-tests] | ||
| if: always() && needs.validate-inputs.result == 'success' && (needs.pre-release-tests.result == 'success' || needs.pre-release-tests.result == 'skipped') | ||
| needs: [validate-inputs, pre-release-tests, pre-release-slow-tests] | ||
| if: always() && needs.validate-inputs.result == 'success' && (needs.pre-release-tests.result == 'success' || needs.pre-release-tests.result == 'skipped') && (needs.pre-release-slow-tests.result == 'success' || needs.pre-release-slow-tests.result == 'skipped') | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| id-token: write # Needed to federate a token for the bump-PR create-release step | ||
| steps: | ||
| - name: Check test results | ||
| if: ${{ inputs.dry_run != true && inputs.skip_tests != true && inputs.release_type != 'retag' && needs.pre-release-tests.result != 'success' }} | ||
| if: ${{ inputs.dry_run != true && inputs.skip_tests != true && inputs.release_type != 'retag' && (needs.pre-release-tests.result != 'success' || needs.pre-release-slow-tests.result != 'success') }} | ||
| run: | | ||
| echo "::error::Pre-release tests failed. Cannot proceed with release." | ||
| exit 1 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuring the slow suite only for
debugmeans the newly tagged tests are excluded from both nightly and pre-release ASan tasks, while notestSlowAsaninvocation replaces that coverage. This is particularly harmful forWriteStackTracesAfterClassUnloadTest, whose own documentation says non-sanitized runs can stay green on the use-after-free and that ASan/UBSan is the authoritative signal; includeasanin a slow-suite workflow so this regression remains detectable.AGENTS.md reference: AGENTS.md:L324-L328
Useful? React with 👍 / 👎.