overrides get command - #278
Merged
Merged
Conversation
rabiaq123
force-pushed
the
DVC-8632-overrides-get
branch
from
September 6, 2023 19:36
0456276 to
922ea61
Compare
| this.writer.showResults({ environment: environment.key, variation: null }) | ||
| return | ||
| } | ||
| this.writer.showError( |
Contributor
There was a problem hiding this comment.
this should just be normal output, not showError
chantalchung
reviewed
Sep 7, 2023
| export default class DetailedTargeting extends Base { | ||
| static hidden = false | ||
| authRequired = true | ||
| static description = 'View the overrides associated with your DevCycle Identity in your current project.' |
Contributor
There was a problem hiding this comment.
Suggested change
| static description = 'View the overrides associated with your DevCycle Identity in your current project.' | |
| static description = 'View the Overrides associated with your DevCycle Identity in your current project.' |
| import { fetchEnvironmentByKey } from '../../api/environments' | ||
| import { fetchVariationByKey } from '../../api/variations' | ||
|
|
||
| export default class DetailedTargeting extends Base { |
Contributor
There was a problem hiding this comment.
should this be named something else?
Suggested change
| export default class DetailedTargeting extends Base { | |
| export default class DetailedOverrides extends Base { |
| this.writer.showResults( | ||
| `Override for feature: ${featureKey} on environment: ${environment.key} is variation: <not-set>` | ||
| ) | ||
| this.writer.infoMessageWithCommand('To set an override, use: ', 'dvc overrides update') |
Contributor
There was a problem hiding this comment.
space is not needed here, it's handled in the function
Suggested change
| this.writer.infoMessageWithCommand('To set an override, use: ', 'dvc overrides update') | |
| this.writer.infoMessageWithCommand('To set an override, use:', 'dvc overrides update') |
| this.writer.showResults({ environment: environment.key, variation: null }) | ||
| return | ||
| } | ||
| this.writer.showResults( |
Contributor
There was a problem hiding this comment.
let's use showRawResults here so it doesn't stringify the result again and add extra quotations
Contributor
There was a problem hiding this comment.
you mean line 74, just to be clear?
Contributor
There was a problem hiding this comment.
yup, in non-headless mode
rabiaq123
force-pushed
the
DVC-8632-overrides-get
branch
from
September 7, 2023 19:00
d80f3ac to
131d74f
Compare
rabiaq123
enabled auto-merge (squash)
September 7, 2023 20:01
kaushalkapasi
approved these changes
Sep 7, 2023
…or formatting for no override set
rabiaq123
force-pushed
the
DVC-8632-overrides-get
branch
from
September 7, 2023 21:33
131d74f to
ae5544f
Compare
jonathannorris
pushed a commit
that referenced
this pull request
Aug 11, 2025
override get command logic for when a feature and environment are specified
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dvc overrides get --feature <feature-key> --environment <environment-key>