Skip to content

Split java cloud docs into 3 sections - #232

Merged
emmawillis merged 1 commit into
mainfrom
DVC-6945-java-cloud-install-docs
Apr 14, 2023
Merged

Split java cloud docs into 3 sections#232
emmawillis merged 1 commit into
mainfrom
DVC-6945-java-cloud-install-docs

Conversation

@emmawillis

@emmawillis emmawillis commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Apr 14, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devcycle-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 6:07pm

@emmawillis
emmawillis requested a review from a team April 14, 2023 15:41
aurorawalker
aurorawalker suggested changes Apr 14, 2023
View reviewed changes
Comment thread docs/sdk/example-apps.md Outdated
| [Go](https://github.com/DevCycleHQ/go-server-sdk) | [Go Reference Docs](/sdk/server-side-sdks/go.md) |
| [iOS](https://github.com/devcyclehq/ios-client-sdk) | [iOS Reference Docs](/sdk/client-side-sdks/ios.md) |
| [Java (Cloud Bucketing)](https://github.com/DevCycleHQ/java-server-sdk) | [Java (Cloud Bucketing) Reference Docs](/sdk/server-side-sdks/java-cloud.md) |
| [Java (Cloud Bucketing)](https://github.com/DevCycleHQ/java-server-sdk) | [Java (Cloud Bucketing) Reference Docs](/sdk/server-side-sdks/java-cloud) |

@aurorawalker aurorawalker Apr 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually work? I thought it needed to be changed to /java-cloud/java-cloud.md

@emmawillis emmawillis Apr 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works! it links to the same page

@emmawillis emmawillis Apr 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although maybe i should keep it consistent with the other links here

Comment thread docs/sdk/server-side-sdks/java-cloud/java-cloud.md Outdated
[![Maven](https://badgen.net/maven/v/maven-central/com.devcycle/java-server-sdk)](https://search.maven.org/artifact/com.devcycle/java-server-sdk)
[![GitHub](https://img.shields.io/github/stars/devcyclehq/java-server-sdk.svg?style=social&label=Star&maxAge=2592000)](https://github.com/DevCycleHQ/java-server-sdk)

## Requirements

@aurorawalker aurorawalker Apr 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want requirements in the 'installation' section - I believe it is also info we want pop up in context when installing (at least, that's what I've done on some other sections I've worked on).

@emmawillis emmawillis Apr 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh true that makes sense, i'll move it

@emmawillis
emmawillis force-pushed the DVC-6945-java-cloud-install-docs branch from 0a1d57d to e9f7fa0 Compare April 14, 2023 16:46
@emmawillis
emmawillis force-pushed the DVC-6945-java-cloud-install-docs branch from e9f7fa0 to 648b40f Compare April 14, 2023 16:50
@emmawillis
emmawillis requested a review from aurorawalker April 14, 2023 17:20
aurorawalker
aurorawalker suggested changes Apr 14, 2023
View reviewed changes
Comment thread docs/sdk/server-side-sdks/java-cloud/java-cloud.md

The SDK is available as a package on MavenCentral. It is also open source and can be viewed on Github.

[![Maven](https://badgen.net/maven/v/maven-central/com.devcycle/java-server-sdk)](https://search.maven.org/artifact/com.devcycle/java-server-sdk)

@aurorawalker aurorawalker Apr 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New requirement as per the slack conversations - we now want these badges at the top of all the subpages for this section.

https://taplytics.slack.com/archives/C032ZGWQPCJ/p1681485912733769

@emmawillis emmawillis Apr 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

Comment thread docs/sdk/features/initialization.md Outdated
### [• Java Local SDK](/sdk/server-side-sdks/java-local#installation)

### [• Java Cloud SDK](/sdk/server-side-sdks/java-cloud#installation)
### [• Java Cloud SDK](/sdk/server-side-sdks/java-cloud/java-cloud-usage#installation)

@aurorawalker aurorawalker Apr 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I steered you wrong on this - new requirement as per slack conversation, we now want this link to point to the 'Getting Started' page

https://taplytics.slack.com/archives/C032ZGWQPCJ/p1681418554428909

@emmawillis emmawillis Apr 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh oops, good catch - fixed now!

@emmawillis
emmawillis force-pushed the DVC-6945-java-cloud-install-docs branch from 648b40f to feb7035 Compare April 14, 2023 17:28
@emmawillis
emmawillis force-pushed the DVC-6945-java-cloud-install-docs branch from feb7035 to 9e5154c Compare April 14, 2023 17:31
@emmawillis
emmawillis force-pushed the DVC-6945-java-cloud-install-docs branch from 9e5154c to c80fd9f Compare April 14, 2023 17:58
@emmawillis
emmawillis force-pushed the DVC-6945-java-cloud-install-docs branch from c80fd9f to 15f1946 Compare April 14, 2023 18:01
@emmawillis
emmawillis requested a review from aurorawalker April 14, 2023 18:02
@emmawillis
emmawillis force-pushed the DVC-6945-java-cloud-install-docs branch from 15f1946 to b0a2dba Compare April 14, 2023 18:04
@emmawillis
emmawillis force-pushed the DVC-6945-java-cloud-install-docs branch from b0a2dba to c8f4219 Compare April 14, 2023 18:06
@emmawillis
emmawillis merged commit 634c543 into main Apr 14, 2023
@emmawillis
emmawillis deleted the DVC-6945-java-cloud-install-docs branch April 14, 2023 18:27
jonathannorris added a commit that referenced this pull request Jul 27, 2026
@jonathannorris
chore: resolve open dependabot security alerts
5203d10 
- fast-uri 3.1.2 -> 3.1.4 (high, alerts #236, #239)
- svgo 3.3.3 -> 3.3.4 (high, alert #238)
- dompurify 3.4.11 -> 3.4.12 (low, alert #237)
- body-parser 1.20.4 -> 1.20.6 (low, alert #235)
- webpack-dev-server 5.2.5 -> 5.2.6 (medium, alerts #233, #234)
- shell-quote 1.8.4 -> 1.9.0 (high, alert #232)
- brace-expansion 2.1.1 -> 2.1.2 (high, alert #231)
- brace-expansion 1.1.15 -> 1.1.16 (high, alert #230)
@jonathannorris jonathannorris mentioned this pull request Jul 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aurorawalker aurorawalker aurorawalker approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmawillis @aurorawalker