Add LocalBucketing with storeConfig function working - #18
Merged
Conversation
emmawillis
commented
Sep 2, 2022
emmawillis
commented
Contributor
- Add LocalBucketing class with all functions working (except generateBucketedConfig has the wrong return type)
- Add small test for LocalBucketing - we'll probably want to delete this when we finish the DVCLocalClient since tests for that will cover the bucketing class
- Add a local client to the test app so we can demo it
- Also renamed local/DVCClient to DVCLocalClient (do we want to do this??)
emmawillis
force-pushed
the
DVC-4203-add-wasm
branch
from
September 2, 2022 17:58
d96ee8e to
a6f4a24
Compare
JamieSinn
requested changes
Sep 5, 2022
emmawillis
force-pushed
the
DVC-4203-add-wasm
branch
4 times, most recently
from
September 7, 2022 03:30
d101aab to
dabe136
Compare
JamieSinn
reviewed
Sep 7, 2022
| private final DVCApi api; | ||
| private final DVCOptions dvcOptions; | ||
|
|
||
| private static final LocalBucketing localBucketing = new LocalBucketing(); |
Member
There was a problem hiding this comment.
I don't think we want this to be final; static alone is fine.
JamieSinn
reviewed
Sep 7, 2022
| public DVCClient(String serverKey, DVCOptions dvcOptions) { | ||
| public DVCLocalClient(String serverKey, DVCOptions dvcOptions) { | ||
| new EnvironmentConfigManager(serverKey, dvcOptions); | ||
| DEFAULT_SDK_VERSION = "1.1.0"; |
Member
There was a problem hiding this comment.
You're declaring this as final, it can be set in the initialization.
JamieSinn
reviewed
Sep 7, 2022
JamieSinn
reviewed
Sep 7, 2022
JamieSinn
reviewed
Sep 7, 2022
JamieSinn
reviewed
Sep 7, 2022
| byte[] headerBytes = {buf.get(startAddress - 1), buf.get(startAddress - 2), buf.get(startAddress - 3), buf.get(startAddress - 4)}; | ||
| long stringLength = getUnsignedInt(headerBytes); | ||
| String result = ""; | ||
| for (int i = 0; i < stringLength; i += 2) { // +=2 because every 2nd byte is null |
Member
There was a problem hiding this comment.
Technically this comment is correct, but it's because the data is formatted as WTF-16 - not UTF-8. So technically the second byte is a valid data byte - but we're not using it, so we skip. Not that the byte is \0.
Contributor
Author
There was a problem hiding this comment.
oh that makes sense, i'll just put that it's formatted as WTF-16 instead of UTF-8, hopefully that will be more helpful
JamieSinn
requested changes
Sep 7, 2022
| String bucketedConfigString = readWasmString(resultAddress); | ||
|
|
||
| Map<String, Object> mapping = new ObjectMapper().readValue(bucketedConfigString, HashMap.class); | ||
| // TODO parse json as BucketedUserConfig class and return that |
Member
There was a problem hiding this comment.
Lets make sure we finish this before merging.
Contributor
Author
There was a problem hiding this comment.
that's already finished in the next commit, i'm going to PR it right after this one. just trying to get this into the feature branch to unblock Kaushal
Member
There was a problem hiding this comment.
Just because of how WASM is painful - I'd do it in this one.
emmawillis
force-pushed
the
DVC-4203-add-wasm
branch
from
September 7, 2022 14:56
dabe136 to
0844a1c
Compare
JamieSinn
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.