Skip to content

split DVCOptions into Cloud and Bucketing Options that implement a common interface - #19

Merged
kaushalkapasi merged 5 commits into
java-local-bucketing-changesfrom
split-dvcOptions-to-local-and-cloud
Sep 8, 2022
Merged

split DVCOptions into Cloud and Bucketing Options that implement a common interface#19
kaushalkapasi merged 5 commits into
java-local-bucketing-changesfrom
split-dvcOptions-to-local-and-cloud

Conversation

@kaushalkapasi

@kaushalkapasi kaushalkapasi commented Sep 6, 2022

Copy link
Copy Markdown
Contributor
  • common DVCOptions interface is currently empty
  • add defaults to DVCCloudOptions for:
    • Enable EdgeDB = false
  • add defaults to DVCLocalOptions for:

@kaushalkapasi
kaushalkapasi requested review from a team and JamieSinn September 6, 2022 18:14
@kaushalkapasi kaushalkapasi changed the title split dvcOptions into Cloud and Bucketing Options that implement a common interface split DVCOptions into Cloud and Bucketing Options that implement a common interface Sep 6, 2022
Comment thread src/main/java/com/devcycle/sdk/server/common/model/DVCOptions.java Outdated
@kaushalkapasi
kaushalkapasi force-pushed the split-dvcOptions-to-local-and-cloud branch from 0873461 to 711a6ea Compare September 7, 2022 15:27
@kaushalkapasi
kaushalkapasi force-pushed the split-dvcOptions-to-local-and-cloud branch from 711a6ea to 347bf3f Compare September 8, 2022 15:28
Comment thread src/main/java/com/devcycle/sdk/server/local/api/DVCLocalClient.java Outdated
@kaushalkapasi
kaushalkapasi force-pushed the split-dvcOptions-to-local-and-cloud branch from 347bf3f to 76fb9e5 Compare September 8, 2022 16:28
@kaushalkapasi
kaushalkapasi merged commit 90bedd5 into java-local-bucketing-changes Sep 8, 2022
@kaushalkapasi
kaushalkapasi deleted the split-dvcOptions-to-local-and-cloud branch September 8, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants